Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Polish clipboardButton #11373

Closed
luixxiul opened this issue Oct 8, 2017 · 1 comment
Closed

Polish clipboardButton #11373

luixxiul opened this issue Oct 8, 2017 · 1 comment
Assignees
@luixxiul
Labels
misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 8, 2017 •
edited
Loading

Test plan

#11374 (comment)

Description

Polish clipboardButton

  • by applying the modified BEM style to dedupe properties
  • by replacing span with browserButton

Brave Version

about:brave info:

3544244

Reproducible on current live release:

Additional Information
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Oct 8, 2017
@luixxiul luixxiul mentioned this issue Oct 8, 2017
Merged
8 tasks
@luixxiul luixxiul self-assigned this Oct 8, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
@cezaraugusto
Polish clipboardButton
bbab253 
- Apply the modified BEM style to dedupe properties
- Add copyToClipboard.title to preferences.properties
- Replace span with browserButton
- Set copyToClipboard.title by default (because it is what we usually want to set)

Closes #11373

Auditors:

Test Plan:
1. Open about:brave
2. Click the clipboard button
3. Make sure the data is copied
4. Open about:preferences#payments
5. Click add funds
6. Click any currency icon
7. Make sure 'Copy to clipboard' is displayed on hover
@luixxiul luixxiul modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Nov 21, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

This was referenced Jun 19, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @srirambv @LaurenWags @btlechowski