This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Apply BrowserButton to clipboardButton #11374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
misc/button
polish
Nice to have — usually related to front-end/visual tasks.
refactoring/aphrodite
labels
Oct 8, 2017
Codecov Report
@@ Coverage Diff @@
## master #11374 +/- ##
==========================================
- Coverage 52.67% 52.01% -0.66%
==========================================
Files 269 269
Lines 25602 25537 -65
Branches 4085 4070 -15
==========================================
- Hits 13485 13284 -201
- Misses 12117 12253 +136
|
blocking for now as this affects add funds on 0.19.x |
bbondy
modified the milestones:
0.21.x (Developer Channel),
0.20.x (Beta Channel),
Backlog
Oct 25, 2017
- Apply the modified BEM style to dedupe properties - Add copyToClipboard.title to preferences.properties - Replace span with browserButton - Set copyToClipboard.title by default (because it is what we usually want to set) Closes #11373 Auditors: Test Plan: 1. Open about:brave 2. Click the clipboard button 3. Make sure the data is copied 4. Open about:preferences#payments 5. Click add funds 6. Click any currency icon 7. Make sure 'Copy to clipboard' is displayed on hover
luixxiul
changed the title
Polish clipboardButton
Apply BrowserButton to clipboardButton
Nov 17, 2017
luixxiul
removed
the
polish
Nice to have — usually related to front-end/visual tasks.
label
Nov 17, 2017
one thing is that with this move we lost the pointer as the cursor. Could make a workaround for this? otherwise this lgtm |
That will be taken care of https://github.com/brave/browser-laptop/pull/10951/files#diff-0ff973318abdc5c07f55cefe86bd5ed7R110 of #10951. Is it OK to wait until that? |
cezaraugusto
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clipboard
fa icon by defaultCloses #11373
Auditors:
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests