Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Additional footer text causes button misalignment #11489

Closed
srirambv opened this issue Oct 12, 2017 · 4 comments · Fixed by #11500
Closed

Additional footer text causes button misalignment #11489

srirambv opened this issue Oct 12, 2017 · 4 comments · Fixed by #11500
Assignees
@NejcZdovc
Labels
feature/rewards misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 release-notes/include
Milestone
0.19.x Hotfix 1 (...

Comments

@srirambv
Copy link
Collaborator

Description

Additional footer text causes button misalignment

Steps to Reproduce

  1. Install 0.19.48
  2. Open payments, click add funds
  3. Click any currency icon, buttons are not aligned

Actual result:

image

Expected result:

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave 0.19.48
rev de939f6
Muon 4.4.28

Reproducible on current live release:

N/A

Additional Information
@srirambv srirambv modified the milestones: 0.19.x (Beta Channel), 0.19.x Release 2 (Beta Channel) Oct 12, 2017
@luixxiul
Copy link
Contributor

By setting display: flex to the footer button wrapper you'll get:

buttons

Removing easily from the string you'll get:

buttons

which looks good on macOS at least. Please make sure this is not a l10n-friendly solution.

@bsclifton
Copy link
Member

@luixxiul would you be able to fix this up? 😄

@luixxiul
Copy link
Contributor

@bradleyrichter which one do you prefer above?

@NejcZdovc
Copy link
Contributor

@luixxiul I would go with the first one because of i10n

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned luixxiul Oct 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 13, 2017
@NejcZdovc
Fixes button alignment in the wizard
97e848d 
Thx @luixxiul for the fix

Resolves brave#11489

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Oct 13, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 13, 2017
@NejcZdovc
Fixes button alignment in the wizard
bc53ab3 
Thx @luixxiul for the fix

Resolves brave#11489

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Oct 13, 2017
@bsclifton
Merge pull request #11500 from NejcZdovc/hotfix/#11489-buttons
c23623c 
Fixes button alignment in the wizard
bsclifton added a commit that referenced this issue Oct 13, 2017
@bsclifton
Merge pull request #11500 from NejcZdovc/hotfix/#11489-buttons
9a52bbb 
Fixes button alignment in the wizard
bsclifton added a commit that referenced this issue Oct 13, 2017
@bsclifton
Merge pull request #11500 from NejcZdovc/hotfix/#11489-buttons
c0637f6 
Fixes button alignment in the wizard
bsclifton added a commit that referenced this issue Oct 13, 2017
@bsclifton
Merge pull request #11500 from NejcZdovc/hotfix/#11489-buttons
5593375 
Fixes button alignment in the wizard
@kjozwiak kjozwiak mentioned this issue Oct 16, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 16, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Fixes button alignment in the wizard
9cb318c 
Thx @luixxiul for the fix

Resolves brave#11489

Auditors:

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 1 (Release channel)
Development

Successfully merging a pull request may close this issue.

Fixes button alignment in the wizard NejcZdovc/browser-laptop
6 participants
@kjozwiak @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags