Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes button alignment in the wizard #11500

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 13, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Thx @luixxiul for the fix

Resolves #11489

Auditors:

Test plan: specified in #11489

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Thx @luixxiul for the fix

Resolves brave#11489

Auditors:

Test Plan:
@NejcZdovc NejcZdovc force-pushed the hotfix/#11489-buttons branch from 97e848d to bc53ab3 Compare October 13, 2017 04:22
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, looks great! 😄 Here's a demo:
add-funds-style-fix

@bsclifton
Copy link
Member

Also looks good when the text is obnoxiously long:
screen shot 2017-10-12 at 10 09 23 pm

@bsclifton bsclifton merged commit c23623c into brave:master Oct 13, 2017
bsclifton added a commit that referenced this pull request Oct 13, 2017
bsclifton added a commit that referenced this pull request Oct 13, 2017
bsclifton added a commit that referenced this pull request Oct 13, 2017
@bsclifton
Copy link
Member

master c23623c
0.21.x 9a52bbb
0.20.x c0637f6
0.19.x 5593375

@luixxiul
Copy link
Contributor

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional footer text causes button misalignment
3 participants