Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

After closing a tab when multiple tab pages are present, tab bar doesn't always leave preview mode #11632

Closed
bbondy opened this issue Oct 23, 2017 · 18 comments · Fixed by #11768 or #11958
Closed

After closing a tab when multiple tab pages are present, tab bar doesn't always leave preview mode #11632

bbondy opened this issue Oct 23, 2017 · 18 comments · Fixed by #11768 or #11958
Assignees
@cezaraugusto
Labels
0.19.x issue first seen in 0.19.x priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.19.x Hotfix 5 (...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 23, 2017 •
edited by luixxiul
Loading

Test plan

#11958 (comment)

Description

Tab bar sometimes looks like this after closing a tab:
screen shot 2017-10-23 at 8 49 37 am

Steps to Reproduce

  1. Create 3 tab pages
  2. Close a tab with your mouse

Actual result:
Sometimes preview mode stays

Expected result:
Preview mode should be gone and new active tab should show selected without the lighter color overlay on the tab bar.

Reproduces how often: [What percentage of the time does it reproduce?]
30%

Brave Version

0.19.62

about:brave info:

Brave: 0.19.62
rev: fe3f350
Muon: 4.5.7
libchromiumcontent: 62.0.3202.62
V8: 6.2.414.32
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:
Yes
@cezaraugusto cezaraugusto self-assigned this Oct 23, 2017
@NumDeP
Copy link

NumDeP commented Oct 26, 2017

HI @bbondy I was wondering could you merge this tab issue (#11526) to Hotfix 3 as I think it's related and would be brilliant if you could offer a fix in the same release. I also made an inference to this issue there. Thanks.

@bbondy
Copy link
Member Author

bbondy commented Oct 26, 2017

I moved it to hotfix 3 @NumDeP

@NumDeP
Copy link

NumDeP commented Oct 26, 2017 •
edited
Loading

Thank you. One thing I noticed is that it isn't much of an issue with Private tabs in case you didn't know already.

Update: @cezaraugusto another member from the community made a suggestion linked to this issue at hand, rather than creating another issue, could you perhaps make the necessary enhancements detailed in the link. Thanks.

https://community.brave.com/t/ui-ux-request-make-tab-preview-fade-in/9734

@NumDeP NumDeP mentioned this issue Oct 28, 2017
Closed
@luixxiul luixxiul added the 0.19.x issue first seen in 0.19.x label Nov 2, 2017
cezaraugusto added a commit that referenced this issue Nov 2, 2017
@cezaraugusto
fix bad tab page preview while closing tabs
4355858 
fix #11632
@cezaraugusto cezaraugusto mentioned this issue Nov 2, 2017
Merged
cezaraugusto added a commit that referenced this issue Nov 2, 2017
@cezaraugusto
fix bad tab page preview while closing tabs
1f3cb6f 
fix #11632
@LaurenWags
Copy link
Member

Still able to reproduce on MacOS using STR in description:
screen shot 2017-11-08 at 5 20 57 pm

@LaurenWags LaurenWags reopened this Nov 8, 2017
@srirambv
Copy link
Collaborator

srirambv commented Nov 8, 2017

Reproed on Windows too

@bsclifton
Copy link
Member

Tentatively moving to the next release- @cezaraugusto, can you check this out?

If there isn't a quick fix (or it'll require more investigation work), let's un-assign the milestone. Thanks 😄

@cezaraugusto
Copy link
Contributor

failing to reproduce locally but I'll take a new look after Sri/Lauren reports.

yes next milestone should be fine. thanks

cezaraugusto added a commit that referenced this issue Nov 14, 2017
@cezaraugusto
fix bad tab page preview while closing tabs
c9e37f3 
Auditors: @bbondy
fix #11632
@cezaraugusto cezaraugusto mentioned this issue Nov 14, 2017
Merged
This was referenced Nov 15, 2017
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Reopening the issue based on #11958 (comment)
11632

@srirambv srirambv reopened this Nov 15, 2017
@bsclifton
Copy link
Member

bsclifton commented Nov 15, 2017 •
edited
Loading

Reverted (cc: @cezaraugusto)
master ae3f125
0.21.x 1fe5de5
0.20.x b12d8bd
0.19.x d2708a0

@cezaraugusto
Copy link
Contributor

did revert my changes fixed the last issue @srirambv reported? this seems related to wrong index not really previews

@cezaraugusto
Copy link
Contributor

un-reverting the change and moving issue back to hotfix 5 as the issue was fixed, and @srirambv reported that #11632 (comment) is unrelated to this change as still exists after the revert.

@bbondy
Copy link
Member Author

bbondy commented Nov 15, 2017

should this be closed?

@cezaraugusto
Copy link
Contributor

yes I was waiting to post the revert sha

@srirambv srirambv mentioned this issue Nov 15, 2017
Closed
cezaraugusto added a commit that referenced this issue Nov 15, 2017
@cezaraugusto
Bring back merge of pull request #11958
43d36d8 
Auditors: @bsclifton
fixes #11632
-
This reverts the revert. More information in
#11632

This reverts commit 1fe5de5.
cezaraugusto added a commit that referenced this issue Nov 15, 2017
@cezaraugusto
Bring back merge of pull request #11958
3481593 
Auditors: @bsclifton
fixes #11632
-
This reverts the revert. More information in
#11632

This reverts commit b12d8bd.
cezaraugusto added a commit that referenced this issue Nov 15, 2017
@cezaraugusto
Bring back merge of pull request #11958
2e71dfd 
Auditors: @bsclifton
fixes #11632
-
This reverts the revert. More information in
#11632

This reverts commit d2708a0.
@cezaraugusto
Copy link
Contributor

Changes un-reverted

master 2819e39
0.21.x 43d36d8
0.20.x 3481593
0.19.x 2e71dfd

@kjozwiak kjozwiak mentioned this issue Nov 16, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
0.19.x issue first seen in 0.19.x priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 5 (Release channel)