Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs Settings option doesn't work correctly after 0.19.48 update #11526

Closed
NumDeP opened this issue Oct 14, 2017 · 4 comments
Closed

Tabs Settings option doesn't work correctly after 0.19.48 update #11526

NumDeP opened this issue Oct 14, 2017 · 4 comments

Comments

@NumDeP
Copy link

NumDeP commented Oct 14, 2017

Test plan

#12193 (comment)


Have you searched for similar issues? Yes. Edit: I found a separate issue #11632 of the preview issue which I initially thought was a result of the tab bar not working correctly.

Description

I've noticed an error in the tab area, which is when you've got 'Select the next tab' chosen in 'When closing an active tab:', it seems to skip or jump a tab every time you close a tab and it if you've got the 'Show tab preview on hover', after it jumps a tab, it shows a preview of the actual tab it should be on without even moving the mouse over tab.

As a matter of fact I don't think any of the options available in 'When closing an active tab' in about:preferences#tabs is functional.

Steps to Reproduce

Select 'Show tab previews on hover' and right-click and open several youtube videos and I think you'll get a better understanding of it and or open around a dozen or so links and begin closing them.
As I mentioned above, I don't think it matters if you've got 'Select the next tab' or 'Select its parent tab' selected, you should encounter exactly the same results.

Expected result: A comment of expectation has been made here - https://community.brave.com/t/new-tabs-vs-closing-tabs/8748

Reproduces how often: 100%

Brave Version

Brave: 0.19.48
rev: de939f6
Muon: 4.4.28
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Release
OS Platform: Microsoft Windows
OS Release: 10.0.15063
OS Architecture: x64

Reproducible on current live release:

Is this a problem with the live build? Yes.

Additional Information

I didn't want to create another issue as I may be incorrect but previously (I'm probably wrong) whenever I used to to accidentally tear of a tab, closing the tab in the accidentally created new window and pressing Ctrl and T used to re-attach it to the main window and back to its original position, where as now, not only does it not go back to it's original position but it also doesn't display the website the tab was on as it currently displays the Brave dashboard.

@NumDeP
Copy link
Author

NumDeP commented Oct 14, 2017

The issues also also been referenced in the community - https://community.brave.com/t/new-tabs-vs-closing-tabs/8748

@luixxiul
Copy link
Contributor

thanks, we'll work on those issues next week.

@bsclifton
Copy link
Member

cc: @bbondy

@bbondy bbondy modified the milestones: 0.19.x Hotfix 3 (Release channel), Backlog Oct 26, 2017
@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Oct 31, 2017
@luixxiul luixxiul added the 0.19.x issue first seen in 0.19.x label Nov 1, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
petemill added a commit that referenced this issue Dec 7, 2017
…nt from the tab muon will set.

Avoids race condition that can occur after will-destroy, before appState has been fully updated with any tab details that change from muon as a result of a tab closing.

Fix #11981
Fix #11526
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.19.x Hotfix 9 Dec 20, 2017
bsclifton pushed a commit that referenced this issue Dec 20, 2017
…nt from the tab muon will set.

Avoids race condition that can occur after will-destroy, before appState has been fully updated with any tab details that change from muon as a result of a tab closing.

Fix #11981
Fix #11526
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 9, 0.21.x (Developer Channel) Dec 20, 2017
petemill added a commit that referenced this issue Dec 22, 2017
…nt from the tab muon will set.

Avoids race condition that can occur after will-destroy, before appState has been fully updated with any tab details that change from muon as a result of a tab closing.

Fix #11981
Fix #11526
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants