Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger client boot error: { Error: Cannot find module 'brave-crypto' #11799

Closed
luixxiul opened this issue Nov 6, 2017 · 3 comments
Closed

ledger client boot error: { Error: Cannot find module 'brave-crypto' #11799

luixxiul opened this issue Nov 6, 2017 · 3 comments
Assignees
@bsclifton
Labels
0.19.x issue first seen in 0.19.x bug feature/rewards OS/unix-like/linux OS/Windows QA/checked-Linux QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x Hotfix 5 (...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 6, 2017 •
edited
Loading

Description

ledger client boot error: { Error: Cannot find module 'brave-crypto'

Steps to Reproduce

  1. Clear the profile data
  2. Run the browser
  3. Open about:preferences#payments
  4. Switch on

Actual result:

ledger client boot error:  { Error: Cannot find module 'brave-crypto'
    at Module._resolveFilename (module.js:470:15)
    at Function.Module._resolveFilename (/usr/lib/brave-beta/resources/electron.asar/common/reset-search-paths.js:41:12)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at /usr/lib/brave-beta/resources/app.asar/node_modules/bat-client/index.js:7:21
    at Object.<anonymous> (/usr/lib/brave-beta/resources/app.asar/node_modules/bat-client/index.js:1431:2)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32) code: 'MODULE_NOT_FOUND' }

Expected result:

Reproduces how often:

Consistently.

Brave Version

about:brave info:

Brave: 0.20.5
V8: 6.2.414.36
rev: 0cc4f80
Muon: 4.5.14
OS Release: 4.9.0-3-amd64
Update Channel: Beta
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 62.0.3202.75

Reproducible on current live release:

I'm not sure.

Additional Information
@luixxiul luixxiul added 0.20.x issue first seen in 0.20.x bug feature/rewards labels Nov 6, 2017
@luixxiul luixxiul modified the milestone: 0.20.x (Beta Channel) Nov 6, 2017
@luixxiul luixxiul added 0.19.x issue first seen in 0.19.x and removed 0.20.x issue first seen in 0.20.x labels Nov 13, 2017
@luixxiul
Copy link
Contributor Author

@srirambv confirmed it was reproducible on 0.19.x.

@bsclifton bsclifton self-assigned this Nov 13, 2017
bsclifton added a commit that referenced this issue Nov 13, 2017
@bsclifton
Remove brave wildcards (we might want a better regex or put the whole…
41dc7cf 
… path)

This causes an issue because we have a dep called `brave-crypto`

Fixes #11799

Auditors: @darkdh
@bsclifton
Copy link
Member

Was caused by e7165b5#diff-eb1f8c8a44791e608fb0fbe96819221eR59 when fixing #11929

We'll need to fix this also for 0.20.x+ (cc: @darkdh). For 0.19.x, I backed out the Brave/brave wildcards for ignore (put in place so that other channels don't get packaged also) and am confirming this fix now.

@bsclifton
Copy link
Member

Fixed with 41dc7cf

@bsclifton bsclifton mentioned this issue Nov 13, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
0.19.x issue first seen in 0.19.x bug feature/rewards OS/unix-like/linux OS/Windows QA/checked-Linux QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 5 (Release channel)
Development

No branches or pull requests
4 participants
@kjozwiak @luixxiul @bsclifton @srirambv