You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
While on the same machine, if you build a package for beta channel and then one for nightly, the nightly package will be significantly larger. This is because the build-package step will pack the beta content into the nightly's ASAR file
A fix for this issue was introduced with #10552, but it has a side-effect of causing this issue: #11799
In the 0.19.x branch, the ignorePaths was removed with 41dc7cf
Note the size of the resources/app.asar (should be ~266 megs, not > 1 GB)
Brave Version
0.20.x and newer (when packaging)
Reproducible on current live release:
No
Additional Information
This should be fixable by either hardcoding the names or creating a stronger regex match (which matches only the builds, not libraries like brave-crypto)
The text was updated successfully, but these errors were encountered:
fix#11939
Auditors: @bsclifton
Test Plan:
(Test on all platforms)
1. CHANNEL=beta npm run build-package
2. CHANNEL=beta npm run build-installer
3. CHANNEL=nightly npm run build-package
4. Note the size of the resources/app.asar (should be ~266 megs, not > 1GB)
Test plan
#11991 (comment)
Description
While on the same machine, if you build a package for
beta
channel and then one fornightly
, thenightly
package will be significantly larger. This is because thebuild-package
step will pack thebeta
content into the nightly's ASAR fileA fix for this issue was introduced with #10552, but it has a side-effect of causing this issue:
#11799
In the 0.19.x branch, the ignorePaths was removed with 41dc7cf
Steps to Reproduce
CHANNEL=beta npm run build-package
CHANNEL=beta npm run build-installer
CHANNEL=nightly npm run build-package
resources/app.asar
(should be ~266 megs, not > 1 GB)Brave Version
0.20.x and newer (when packaging)
Reproducible on current live release:
No
Additional Information
This should be fixable by either hardcoding the names or creating a stronger regex match (which matches only the builds, not libraries like
brave-crypto
)The text was updated successfully, but these errors were encountered: