This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Clean legacy build/install generation before each packaging #11991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #11939 Auditors: @bsclifton Test Plan: (Test on all platforms) 1. CHANNEL=beta npm run build-package 2. CHANNEL=beta npm run build-installer 3. CHANNEL=nightly npm run build-package 4. Note the size of the resources/app.asar (should be ~266 megs, not > 1GB)
bsclifton
modified the milestones:
0.20.x (Beta Channel),
0.19.x Hotfix 6 (Release channel)
Nov 17, 2017
darkdh
commented
Nov 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Codecov Report
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
+ Coverage 53.34% 53.38% +0.04%
==========================================
Files 274 274
Lines 26040 26018 -22
Branches 4170 4170
==========================================
- Hits 13891 13890 -1
+ Misses 12149 12128 -21
|
bsclifton
approved these changes
Nov 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on macOS, Windows, and Linux! 👍 Nice job on this one 😄 Because we are still doing 0.19.x builds, I set this for 0.19.x milestone so that we have clean builds
bsclifton
added a commit
that referenced
this pull request
Nov 17, 2017
Clean legacy build/install generation before each packaging
bsclifton
added a commit
that referenced
this pull request
Nov 17, 2017
Clean legacy build/install generation before each packaging
bsclifton
added a commit
that referenced
this pull request
Nov 17, 2017
Clean legacy build/install generation before each packaging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11939
Auditors: @bsclifton
Test Plan:
(Test on all platforms)
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests