Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clean legacy build/install generation before each packaging #11991

Merged
merged 2 commits into from
Nov 17, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 16, 2017

fix #11939

Auditors: @bsclifton

Test Plan:
(Test on all platforms)

  1. CHANNEL=beta npm run build-package
  2. CHANNEL=beta npm run build-installer
  3. CHANNEL=nightly npm run build-package
  4. Note the size of the resources/app.asar (should be ~266 megs, not > 1GB)

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #11939

Auditors: @bsclifton

Test Plan:
(Test on all platforms)
1. CHANNEL=beta npm run build-package
2. CHANNEL=beta npm run build-installer
3. CHANNEL=nightly npm run build-package
4. Note the size of the resources/app.asar (should be ~266 megs, not > 1GB)
@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Nov 16, 2017
@darkdh darkdh self-assigned this Nov 16, 2017
@darkdh darkdh requested a review from bsclifton November 16, 2017 01:55
@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 6 (Release channel) Nov 17, 2017
Copy link
Member Author

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #11991 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11991      +/-   ##
==========================================
+ Coverage   53.34%   53.38%   +0.04%     
==========================================
  Files         274      274              
  Lines       26040    26018      -22     
  Branches     4170     4170              
==========================================
- Hits        13891    13890       -1     
+ Misses      12149    12128      -21
Flag Coverage Δ
#unittest 53.38% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
js/about/newtab.js 49.68% <0%> (-0.07%) ⬇️
js/constants/appConstants.js 100% <0%> (ø) ⬆️
app/browser/api/ledger.js 44.62% <0%> (+0.19%) ⬆️
js/actions/appActions.js 17.99% <0%> (+0.48%) ⬆️
app/browser/reducers/ledgerReducer.js 44% <0%> (+1.89%) ⬆️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on macOS, Windows, and Linux! 👍 Nice job on this one 😄 Because we are still doing 0.19.x builds, I set this for 0.19.x milestone so that we have clean builds

@bsclifton bsclifton merged commit 573a95b into master Nov 17, 2017
@bsclifton bsclifton deleted the issue-11939 branch November 17, 2017 23:43
bsclifton added a commit that referenced this pull request Nov 17, 2017
Clean legacy build/install generation before each packaging
bsclifton added a commit that referenced this pull request Nov 17, 2017
Clean legacy build/install generation before each packaging
bsclifton added a commit that referenced this pull request Nov 17, 2017
Clean legacy build/install generation before each packaging
@bsclifton
Copy link
Member

master 573a95b
0.21.x bf51642
0.20.x ff1747b
0.19.x 71257de

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folders from other channels need to be disregarded when building package
4 participants