Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

continually prompted to play YT videos #12382

Closed
LaurenWags opened this issue Dec 22, 2017 · 4 comments · Fixed by #12424
Closed

continually prompted to play YT videos #12382

LaurenWags opened this issue Dec 22, 2017 · 4 comments · Fixed by #12424
Assignees
@darkdh
Labels
0.20.x issue first seen in 0.20.x bug feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 22, 2017 •
edited by srirambv
Loading

Description

If you have 'Autoplay Media' set to 'Always ask' and you do not select 'remember this decision', you will be continually prompted to 'Allow youtube to autoplay media?' and can't actually view the video.

Steps to Reproduce

MacOS steps:

  1. Clean profile on 0.20.9
  2. Navigate to about:preferences#security
  3. Set Autoplay Media to 'Always ask'
  4. Clear any pre-set settings for Autoplay Media (for YT and Twitch)
  5. Navigate to YT, select a video to display
  6. Notification displays, select Allow.
  7. Video plays for a split second and then you get the notification again.
  8. Navigate to a different site to view a video (I used an nytimes.com article with a video)
  9. Notification displays, select Allow.
  10. Video plays without issue.

Win/Linux steps (slightly different):

  1. Clean profile on 0.20.9
  2. Navigate to about:preferences#security
  3. Set Autoplay Media to 'Always ask'
  4. Clear any pre-set settings for Autoplay Media (for YT and Twitch)
  5. Navigate to YT, select a video to display
  6. Video plays without any notification bar (this is pre-existing on 0.19.122) (Auto play site settings is retained even after clearing it until browser restart #12514)
  7. Restart browser, navigate to YT video.
  8. Notification displays, select Allow.
  9. Video plays for a split second and then you get the notification again.
  10. Navigate to a different site to view a video (I used an nytimes.com article with a video)
  11. Notification displays, select Allow.
  12. Video plays without issue.

Actual result:
Unless you select 'Remember this decision' you will be continually prompted for YT videos and cannot actually view them.

play-notif

Expected result:
You should only have to select 'Allow' once and then the YT video should play. (this is how this works on 0.19.122

Reproduces how often:
Easily

Brave Version

about:brave info:
0.20.9

Reproducible on current live release:
no, not reproducible on 0.19.122

Additional Information

See slightly different Win/Linux steps which were confirmed by @srirambv and @kjozwiak
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Dec 22, 2017
@petemill
Copy link
Member

I can reproduce the Win/Lunux-only steps above, on Mac

petemill added a commit to petemill/browser-laptop that referenced this issue Dec 23, 2017
@petemill
Make sure temporary media autoplay setting is not removed until after…
a05356d 
… the media is temporarily auto-played

Fix brave#12382
petemill added a commit to petemill/browser-laptop that referenced this issue Dec 23, 2017
@petemill
Make sure temporary media autoplay setting is not removed until after…
6d988a4 
… the media is temporarily auto-played

Fix brave#12382
@petemill petemill mentioned this issue Dec 23, 2017
Closed
10 tasks
@petemill petemill self-assigned this Dec 23, 2017
@darkdh darkdh self-assigned this Dec 27, 2017
darkdh added a commit that referenced this issue Dec 28, 2017
@darkdh
media-started-playing & media-paused refactor
82e9f9f 
fix #12382

Auditors: @bridiver, @bsclifton

Test Plan:
a. Test speaking icon
a.1 Play any video with sounds
a.2 There should be speaking indicator on tab
a.3 Pause the video
a.4 The icon in a.2 should be gone

b Temporary allow for autoplay
b.0 Make sure there is no autoplay rule for test site (youtube)
b.1 Play any videoes
b.2 Autoplay banner will show up
b.3 Click allow and not remember
b.4 Video can continue playing
b.5 Check about:preferences#security, there should be autoplay rule for it
b.6 Close the tab
b.7 Check about:preferences#security, the rule should be gone
b.8 Repeat b.1 - b.5
b.9 Relaunch Brave
b.10 Check about:preferences#security, the rule should be gone
@darkdh darkdh mentioned this issue Dec 28, 2017
Merged
10 tasks
@petemill petemill removed their assignment Dec 28, 2017
darkdh added a commit that referenced this issue Dec 28, 2017
@darkdh
media-started-playing & media-paused refactor
0a2d29e 
fix #12382

Auditors: @bridiver, @bsclifton

Test Plan:
a. Test speaking icon
a.1 Play any video with sounds
a.2 There should be speaking indicator on tab
a.3 Pause the video
a.4 The icon in a.2 should be gone

b Temporary allow for autoplay
b.0 Make sure there is no autoplay rule for test site (youtube)
b.1 Play any videoes
b.2 Autoplay banner will show up
b.3 Click allow and not remember
b.4 Video can continue playing
b.5 Check about:preferences#security, there should be autoplay rule for it
b.6 Close the tab
b.7 Check about:preferences#security, the rule should be gone
b.8 Repeat b.1 - b.5
b.9 Relaunch Brave
b.10 Check about:preferences#security, the rule should be gone

c Temporary allow for autoplay (ignore banner)
c.0 Make sure there is no autoplay rule for test site (youtube)
c.1 Play any videoes
c.2 Autoplay banner will show up
c.3 Click play button on video
c.4 Video can continue playing (banner will be dismissed)
c.5 Check about:preferences#security, there should be autoplay rule for it
c.6 Close the tab
c.7 Check about:preferences#security, the rule should be gone
c.8 Repeat c.1 - c.5
c.9 Relaunch Brave
c.10 Check about:preferences#security, the rule should be gone
darkdh added a commit that referenced this issue Dec 28, 2017
@darkdh
media-started-playing & media-paused refactor
c0b17ae 
fix #12382

Auditors: @bridiver, @bsclifton

Test Plan:
a. Test speaking icon
a.1 Play any video with sounds
a.2 There should be speaking indicator on tab
a.3 Pause the video
a.4 The icon in a.2 should be gone

b Temporary allow for autoplay
b.0 Make sure there is no autoplay rule for test site (youtube)
b.1 Play any videoes
b.2 Autoplay banner will show up
b.3 Click allow and not remember
b.4 Video can continue playing
b.5 Check about:preferences#security, there should be autoplay rule for it
b.6 Close the tab
b.7 Check about:preferences#security, the rule should be gone
b.8 Repeat b.1 - b.5
b.9 Relaunch Brave
b.10 Check about:preferences#security, the rule should be gone

c Temporary allow for autoplay (ignore banner)
c.0 Make sure there is no autoplay rule for test site (youtube)
c.1 Play any videoes
c.2 Autoplay banner will show up
c.3 Click play button on video
c.4 Video can continue playing (banner will be dismissed)
c.5 Check about:preferences#security, there should be autoplay rule for it
c.6 Close the tab
c.7 Check about:preferences#security, the rule should be gone
c.8 Repeat c.1 - c.5
c.9 Relaunch Brave
c.10 Check about:preferences#security, the rule should be gone
This was referenced Jan 2, 2018
Closed
Closed
Closed
@darkdh darkdh modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2018

Clearing flags as this was tested against 0.20.x, needs to be re-tested against 0.19.x.

@srirambv
Copy link
Collaborator

srirambv commented Jan 5, 2018

Verified on 0.19.126. Works fine. #12514 is still an issue which requires restart for settings to take effect.

This was referenced Jan 5, 2018
Closed
Closed
@kjozwiak kjozwiak modified the milestones: 0.19.x Hotfix 11 (Release Channel), 0.20.x (Beta Channel) Jan 5, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2018

As per our discussion in Slack last night, I'm moving this back into the 0.20.x milestone. This particular issue was only reproducible under 0.20.x and wasn't an issue in 0.19.x. However, because the refactored code from this bug was required in 0.19.x, QA double checked and made sure this didn't regress anything in 0.19.x. It passed on all three platforms and was tagged as Checked.

Cleared the Checked tags so it gets retested in 0.20.x.

This was referenced Jan 9, 2018
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
@srirambv srirambv mentioned this issue Jan 24, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.20.x issue first seen in 0.20.x bug feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

media-started-playing & media-paused refactor brave/browser-laptop
6 participants
@petemill @kjozwiak @bsclifton @darkdh @srirambv @LaurenWags