Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Auto play site settings is retained even after clearing it until browser restart #12514

Closed
srirambv opened this issue Jan 5, 2018 · 4 comments · Fixed by #12785
Closed

Auto play site settings is retained even after clearing it until browser restart #12514

srirambv opened this issue Jan 5, 2018 · 4 comments · Fixed by #12785
Assignees
@darkdh
Labels
0.19.x issue first seen in 0.19.x bug feature/autoplay priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 5, 2018 •
edited by bsclifton
Loading

Test plan

See #12785

Description

Found while testing #12149, Auto play site settings is retained even after clearing it.

Steps to Reproduce

  1. Clean install 0.19.126
  2. Clear auto play site setting in security
  3. Change autoplay setting to always ask
  4. Visit YT in a new tab and play video, notification bar not shown for autoplay, video starts playing
  5. Visit Vimeo in a new tab and play video, notification bar is shown to allow playing video

Actual result:
12149

Expected result:
Should ask to allow video playback for YT when the site setting is cleared

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.126
rev a8cd0cc
Muon 4.5.35
libchromiumcontent 63.0.3239.108
V8 6.3.292.48
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.16299
OS Architecture x64

Reproducible on current live release:
Yes

Additional Information
@srirambv srirambv changed the title Auto play site settings is retained even after clearing it Auto play site settings is retained even after clearing it until browser restart Jan 5, 2018
@LaurenWags LaurenWags mentioned this issue Jan 5, 2018
Closed
@srirambv srirambv added 0.20.x issue first seen in 0.20.x and removed 0.19.x issue first seen in 0.19.x labels Jan 5, 2018
@srirambv
Copy link
Collaborator Author

srirambv commented Jan 5, 2018

Moving to 20.x as its an existing behaviour

@srirambv srirambv modified the milestones: 0.19.x Hotfix 11 (Release Channel), 0.20.x (Beta Channel) Jan 5, 2018
@LaurenWags
Copy link
Member

I can't reproduce in 0.19.123 on MacOS:
12514-019123

@bsclifton bsclifton self-assigned this Jan 6, 2018
@alexwykoff alexwykoff added 0.19.x issue first seen in 0.19.x priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed 0.20.x issue first seen in 0.20.x labels Jan 9, 2018
@bsclifton
Copy link
Member

cc: @srirambv @kjozwiak can you please retest this? 😄

@darkdh
Copy link
Member

darkdh commented Jan 22, 2018

The culprit is Clear All which will not have effect immediately so it is not Windows specific

darkdh added a commit that referenced this issue Jan 22, 2018
@darkdh
Update content setttings after site settings cleared
e3f7d3c 
fix #12514

Auditors: @bridiver, @bsclifton

Test Plan:
1. Set autoplay global setting to `Always Ask`
2. Make sure there is autoplay always allow for youtube (if not just
                                                         make one)
3. Go to any youtube video, it should be autoplaying
4. Go to about:preferences#security
5. `Clear all` on autoplay site settings
6. Go to any youtube video, it should ask you about autoplay permission
@darkdh darkdh mentioned this issue Jan 22, 2018
Merged
10 tasks
This was referenced Jan 24, 2018
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.19.x issue first seen in 0.19.x bug feature/autoplay priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update content setttings after site settings cleared brave/browser-laptop
6 participants
@alexwykoff @kjozwiak @bsclifton @darkdh @srirambv @LaurenWags