Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autoplay shouldn't block user initialized video #12149

Closed
darkdh opened this issue Nov 30, 2017 · 0 comments · Fixed by brave/muon#394
Closed

Autoplay shouldn't block user initialized video #12149

darkdh opened this issue Nov 30, 2017 · 0 comments · Fixed by brave/muon#394

Comments

@darkdh
Copy link
Member

darkdh commented Nov 30, 2017

Test plan

  1. Go to https://blog.google/products/photos/google-photos-500-million-new-sharing/
  2. Try to play the main video
  3. It should play; before it would spin until you accept via the auto-play alert bar

Original issue description

#8739 (comment)

go here: https://blog.google/products/photos/google-photos-500-million-new-sharing/

Then try to play the main video. It spins until you accept the auto-play alert bar.

This is not how it should work. This video should play when you press the play button regardless of how autoplay is set for this page.

Must fix or pull. : (


#8739 (comment)

from @bradleyrichter, regarding https://boingboing.net/2017/06/21/brave-orfox-firefox-focus.html

We need to improve the auto-play blocking. The top video on this page does not seem to be set to autoplay but we make it hard for the user to play the video which won’t play until you accept the alert.

@darkdh darkdh self-assigned this Nov 30, 2017
darkdh added a commit to brave/muon that referenced this issue Dec 1, 2017
darkdh added a commit to brave/muon that referenced this issue Dec 1, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 18, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 21, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 27, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Dec 29, 2017
@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.