Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autoplay notification should not be shown for local files #8929

Closed
srirambv opened this issue May 18, 2017 · 0 comments · Fixed by brave/muon#394
Closed

Autoplay notification should not be shown for local files #8929

srirambv opened this issue May 18, 2017 · 0 comments · Fixed by brave/muon#394

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 18, 2017

Test Plan

  1. Clean install the build
  2. Open a mp4 file from local machine
  3. Video should start playing and no auto play notification should be shown

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Autoplay notification shown for local files instead of playing the video upload load

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.15.304
    rev b872523
    Muon 3.0.103

  • Steps to reproduce:

    1. Open a new tab and open a .mp4 file from machine
    2. Auto play notification is shown instead of playing the video automatically
  • Actual result:
    Autoplay notification shown for local files

  • Expected result:
    For local files loaded in browser there should not be any autoplay notification shown.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @darkdh

@srirambv srirambv added this to the 0.15.400 milestone May 18, 2017
@alexwykoff alexwykoff removed this from the 0.16.100 milestone May 23, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
darkdh added a commit to brave/muon that referenced this issue Dec 1, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 18, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 21, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 27, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
@darkdh darkdh modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Dec 29, 2017
@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
@bsclifton bsclifton changed the title Autoplay notification shown for local files Don't show autoplay notification for local files Jan 4, 2018
@bsclifton bsclifton changed the title Don't show autoplay notification for local files Autoplay notification should not be shown for local files Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.