This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Autoplay issues fix #394
Merged
Autoplay issues fix #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
browser-laptop-issue-11527
branch
3 times, most recently
from
7c1bbd3 to
a3fff6b
Compare
darkdh
changed the title
darkdh
force-pushed
the
browser-laptop-issue-11527
branch
from
a3fff6b to
4850c4f
Compare
|
rebased |
bridiver
reviewed
Dec 21, 2017
patches/master_patch.patch
Outdated
| @@ -1920,6 +1908,7 @@ index 9162bc3ba51153a494aa218007511054cdebbad7..e685ea161db22661d3a643cd37df8924 | |||
| - element_->GetDocument() | |||
There was a problem hiding this comment.
can you change this to use MUON_CHROMIUM_BUILD? It's hard to read the diff like this and so I'm a little confused about part of it
There was a problem hiding this comment.
good call, addressed in 8a54a8f
darkdh
force-pushed
the
browser-laptop-issue-11527
branch
2 times, most recently
from
8a54a8f to
614c802
Compare
darkdh
force-pushed
the
browser-laptop-issue-11527
branch
3 times, most recently
from
a599bca to
21d55fd
Compare
fix brave/browser-laptop#11988 fix brave/browser-laptop#11527 2. Don't check user initiated video fix brave/browser-laptop#12149 3. Default allow muted media fix brave/browser-laptop#12152 4. Default allow for local files fix brave/browser-laptop#8929 Auditors: @bridiver, @bbondy, @bsclifton
darkdh
force-pushed
the
browser-laptop-issue-11527
branch
from
21d55fd to
6e029ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio element should also repect auotplay setting
fix Music on vk.com may not play reliably browser-laptop#11988
fix DOMException: play() can only be initiated by a user gesture browser-laptop#11527
Don't check user initiated video
fix Autoplay shouldn't block user initialized video browser-laptop#12149
Default allow muted media
fix revert muted media should be able to autoplay browser-laptop#12152
Default allow for local files
fix Autoplay notification should not be shown for local files browser-laptop#8929
Auditors: @bridiver, @bbondy, @bsclifton