Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extensions icon broken on about:extensions #12409

Closed
srirambv opened this issue Dec 27, 2017 · 0 comments · Fixed by #12412
Closed

Extensions icon broken on about:extensions #12409

srirambv opened this issue Dec 27, 2017 · 0 comments · Fixed by #12412
Assignees
@diracdeltas
Labels
0.20.x issue first seen in 0.20.x bug feature/about-pages feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

Description

Extensions icon broken on about:extensions

Steps to Reproduce

  1. Clean install 0.20.11
  2. Open about:preferences#extensions, PDF and Torrent viewer icon is broken
  3. Enable all extensions, open about:extensions, all extension icons are broken

Actual result:
image

Expected result:
Should show proper extension icon

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.11
V8 6.3.292.48
rev 9bb3c67
Muon 4.5.31
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 63.0.3239.108

Reproducible on current live release:
No

Additional Information
@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Dec 27, 2017
@diracdeltas diracdeltas self-assigned this Dec 27, 2017
@bsclifton bsclifton assigned bsclifton and unassigned bsclifton Dec 27, 2017
diracdeltas added a commit that referenced this issue Dec 27, 2017
@diracdeltas
Fix extension icons appearing on pages
0b14695 
fix #12409

Test Plan:
1. go to about:preferences#extensions, all icons should appear.
2. enable pocket. the browserAction icon should appear in the top right of the browser.
3. go to about:extensions. all icons should appear.
4. go to any page and right-click. the pocket icon should appear in the context menu.
@diracdeltas diracdeltas mentioned this issue Dec 27, 2017
Merged
10 tasks
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
0.20.x issue first seen in 0.20.x bug feature/about-pages feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix extension icons appearing in about: pages and context menu brave/browser-laptop
6 participants
@diracdeltas @kjozwiak @luixxiul @bsclifton @srirambv @LaurenWags