This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix extension icons appearing in about: pages and context menu #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #12409 Test Plan: 1. go to about:preferences#extensions, all icons should appear. 2. enable pocket. the browserAction icon should appear in the top right of the browser. 3. go to about:extensions. all icons should appear. 4. go to any page and right-click. the pocket icon should appear in the context menu.
diracdeltas
commented
Dec 27, 2017
| @@ -408,7 +408,7 @@ module.exports.init = () => { | |||
| extensionInfo.setInstallInfo(installInfo.id, installInfo) | |||
| installInfo.filePath = installInfo.base_path | |||
|
|
|||
| installInfo.base_path = chromeUrl(installInfo.base_path) | |||
| installInfo.base_path = fileUrl(installInfo.base_path) | |||
There was a problem hiding this comment.
@kevinlawler i un-did this change from a51b7ea because chrome://brave URLs are not loadable in about: pages and also the code that generated context menu icons assumed a file:// URL. if i'm not mistaken, chrome://brave is only needed for the browser action.
There was a problem hiding this comment.
@diracdeltas with @kevinlawler 's PR before fixed the icons being broken in the top right (part of the UI Chrome). I wonder if we need to store both the Chrome URL + file URL?
There was a problem hiding this comment.
I just verified that with this change, the icons still show up as expected 😄 I now see the change you did by wrapping browserAction! 👍
bsclifton
added a commit
that referenced
this pull request
Dec 27, 2017
Fix extension icons appearing in about: pages and context menu
bsclifton
added a commit
that referenced
this pull request
Dec 27, 2017
Fix extension icons appearing in about: pages and context menu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12409
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests