Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

updates are not working under macOS when using pkg installers #13106

Closed
kjozwiak opened this issue Feb 12, 2018 · 3 comments
Closed

updates are not working under macOS when using pkg installers #13106

kjozwiak opened this issue Feb 12, 2018 · 3 comments
Assignees
@petemill @bsclifton
Labels
0.20.x issue first seen in 0.20.x bug feature/updater OS/macOS QA/checked-macOS QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.20.x Release 2 ...

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 12, 2018 •
edited
Loading

Description

Brave installations using the pkg installers are not updating to the latest version. It's correctly working when using dmg installers. Example:

  • installing 0.20.36 via pkg and updating -> 0.20.37 - FAIL
  • installing 0.20.36 via dmg and updating -> 0.20.37 - PASS

Steps to Reproduce

  1. install 0.20.36
  2. select Hamburger Menu -> About Brave -> Check for Updates..
  3. you'll receive a macOS prompt requesting credentials to install a new helper tool
  4. insert your macOS credentials and select Add Helper
  5. click on Update and Brave will close (notice Brave won't relaunch automatically anymore)
  6. open Brave and visit about:brave, it's still on 0.20.36

Actual result:

Brave is not re-launching/updating pkg installations.

Expected result:

Updates should be correctly working when updating a pkg installation. Should behave the same way dmg installers do.

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.20.36 
V8: 6.4.388.41 
rev: bba0b928164f8b3056a1d9be02c738c66202807c 
Muon: 4.7.10 
OS Release: 17.4.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.140

Reproducible on current live release:

Recent regression when using the pkg installer.

Additional Information
@kjozwiak kjozwiak added this to the 0.20.x Hotfix 2 (Referral Promotion) milestone Feb 12, 2018
@bsclifton bsclifton self-assigned this Feb 12, 2018
@kjozwiak kjozwiak mentioned this issue Feb 12, 2018
Closed
@bsclifton
Copy link
Member

@petemill and I have updated the update-external-binaries.py file in Muon to the latest release (1.2.2 https://github.com/electron/electron-frameworks/releases - was on 1.1.0). This has fixes, such as this one that Pete found:
Squirrel/Squirrel.Mac#207

We're in the process of compiling so we can build a package + try the installation / update process

petemill added a commit that referenced this issue Feb 12, 2018
@petemill
mac - force pkg installed .app to have user-group write-permissions a…
5f11ec9 
…ppropriate to app update feature

Fix #13109
Fix #13106
@petemill petemill mentioned this issue Feb 12, 2018
Merged
10 tasks
@kjozwiak kjozwiak mentioned this issue Feb 13, 2018
Closed
@LaurenWags
Copy link
Member

Checked on MacOS 10.12.6 updating 0.20.39 to 0.20.40:

  • No 'Add Helper'
  • Brave automatically relaunched
  • Verified about:brave was updated as expected

@kjozwiak
Copy link
Member Author

Went through the same test cases that @LaurenWags mentioned above using the following macOS/OSX platforms:

  • macOS 10.13.3 x64 Desktop - PASSED
  • OSX 10.11.6 x64 VM - PASSED
  • OSX 10.10.5 x64 VM - PASSED

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

@bsclifton bsclifton

Labels
0.20.x issue first seen in 0.20.x bug feature/updater OS/macOS QA/checked-macOS QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x Release 2 (Referral Promotion)
Development

No branches or pull requests
4 participants
@petemill @kjozwiak @bsclifton @LaurenWags