Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

mac - set file mode and group owner for pkg-installed Brave.app #13111

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Feb 12, 2018

…appropriate to app update feature

Fix #13109
Fix #13106

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill self-assigned this Feb 12, 2018
@petemill petemill changed the title mac - force pkg installed .app to have user-group write-permissions mac - set file mode and group owner for pkg-installed Brave.app Feb 13, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes worked great in the test executable you sent to me 😄 👍

@bsclifton bsclifton merged commit 076c142 into master Feb 13, 2018
@bsclifton bsclifton deleted the fix/pkg-app-permission branch February 13, 2018 06:49
bsclifton added a commit that referenced this pull request Feb 13, 2018
mac - set file mode and group owner for pkg-installed Brave.app
bsclifton added a commit that referenced this pull request Feb 13, 2018
mac - set file mode and group owner for pkg-installed Brave.app
bsclifton added a commit that referenced this pull request Feb 13, 2018
mac - set file mode and group owner for pkg-installed Brave.app
@bsclifton
Copy link
Member

master 076c142
0.22.x 6174477
0.21.x 6c96cb3
0.20.x 0082152

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants