Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Save link as doesn't add file extension to save dialogue window #13228

Closed
srirambv opened this issue Feb 21, 2018 · 3 comments · Fixed by brave/muon#503
Closed

Save link as doesn't add file extension to save dialogue window #13228

srirambv opened this issue Feb 21, 2018 · 3 comments · Fixed by brave/muon#503
Assignees
@darkdh
Labels
0.21.x issue first seen in 0.21.x muon QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 21, 2018 •
edited
Loading

Test plan

#11906

Description

Save link as doens't add file extension to save dialogue window

Steps to Reproduce

  1. Go to https://brave.com/
  2. Right click on Download Brave
  3. Save Link As
  4. The default path should be your download path
  5. The dialog doesn't have extension option with dmg/exe/deb

Actual result:
11906-savelink

Expected result:
Should detect and add file extension automatically

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.10
V8 6.4.388.41
rev fd80122
Muon 5.0.2
OS Release 10.0.16299
Update Channel  
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:
N/A

Additional Information

Found while testing #11906
@srirambv srirambv added muon 0.21.x issue first seen in 0.21.x labels Feb 21, 2018
@srirambv srirambv added this to the 0.21.x (Beta Channel) milestone Feb 21, 2018
@bsclifton bsclifton changed the title Save link as doens't add file extension to save dialogue window Save link as doesn't add file extension to save dialogue window Feb 21, 2018
darkdh added a commit to brave/muon that referenced this issue Feb 22, 2018
@darkdh
Obtain extension from path when no mime type available
c274fec 
fix brave/browser-laptop#13230
fix brave/browser-laptop#13228

Auditors: @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Feb 22, 2018
Merged
@srirambv srirambv mentioned this issue Feb 22, 2018
Closed
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
This was referenced Mar 2, 2018
Closed
Closed
Closed
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@srirambv
Copy link
Collaborator Author

Works on 0.22.x branch
image

This was referenced Mar 22, 2018
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified that the above issue has been fixed on macOS 10.13.3 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.21.x issue first seen in 0.21.x muon QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Obtain extension from path when no mime type available brave/muon
6 participants
@kjozwiak @bsclifton @darkdh @srirambv @LaurenWags @btlechowski