This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Obtain extension from path when no mime type available #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
approved these changes
Feb 22, 2018
bsclifton
added a commit
that referenced
this pull request
Feb 22, 2018
Obtain extension from path when no mime type available
bridiver
reviewed
Feb 22, 2018
| @@ -139,7 +139,12 @@ void AtomDownloadManagerDelegate::OnDownloadPathGenerated( | |||
| if (path.empty()) { | |||
| std::vector<base::FilePath::StringType> extensions; | |||
| base::FilePath::StringType extension; | |||
| if (GetItemExtension(item, &extension)) { | |||
| if (!GetItemExtension(item, &extension)) { | |||
| extension = target_path.Extension(); | |||
There was a problem hiding this comment.
wouldn't it make more sense to put this code in GetItemExtension?
There was a problem hiding this comment.
yeah, good call. will do a follow up
bridiver
pushed a commit
that referenced
this pull request
Feb 22, 2018
Obtain extension from path when no mime type available
bsclifton
added a commit
that referenced
this pull request
Mar 1, 2018
Obtain extension from path when no mime type available
bsclifton
added a commit
that referenced
this pull request
Mar 1, 2018
Obtain extension from path when no mime type available
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#13230
fix brave/browser-laptop#13228
Auditors: @bridiver, @bsclifton