Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Window buttons looks different on CR65 build #13349

Closed
srirambv opened this issue Mar 1, 2018 · 5 comments
Closed

Window buttons looks different on CR65 build #13349

srirambv opened this issue Mar 1, 2018 · 5 comments
Assignees
@bsclifton
Labels
0.21.x issue first seen in 0.21.x misc/button OS/Windows QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.21.x w/ Chromiu...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 1, 2018

Description

Window buttons looks different on CR65 build

Steps to Reproduce

  1. Install 0.21651
  2. Window buttons looks different even on small screen

Actual result:
Maximized button and close button looks bad
0.21.651 (top) vs 0.21.18(bottom)
image
Restore button looks wrong 0.21.651 (top) vs 0.21.18(bottom)
image

Expected result:
Should show proper buttons

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.651
Brave Sync v1.4.2
libchromiumcontent 65.0.3325.88
Muon 5.1.2
Node.js 7.9.0
OS Architecture x64
OS Platform Microsoft Windows
OS Release 10.0.16299
rev 32c9686
Update Channel Beta
V8 6.5.254.26

Reproducible on current live release:
No

Additional Information

cc: @bsclifton
@srirambv srirambv added regression misc/button 0.21.x issue first seen in 0.21.x labels Mar 1, 2018
@bsclifton bsclifton added this to the 0.21.x w/ Chromium 65 (Beta Channel) milestone Mar 2, 2018
@bsclifton
Copy link
Member

Confirmed this issue doesn't happen at 100% DPI; only at 125 or greater

@bsclifton bsclifton mentioned this issue Mar 9, 2018
Closed
@bsclifton
Copy link
Member

Assigned to @ltilve to investigate; since I've experienced and solved similar Windows issues before, I'll try to help look into this too

@bsclifton
Copy link
Member

bsclifton commented Mar 12, 2018 •
edited
Loading

Doesn't look like this is DPI related. Using the browser dev tools, you can edit the SVG and make it 1 pixel wider... looks great.

Might be related to the breaking CSS changes we've found:
#13373
#13371

bsclifton added a commit that referenced this issue Mar 12, 2018
@bsclifton
Resize viewport associated with SVGs to 11x11. For some reason, DPI >…
9a6ca8b 
… 100% was not scaling these properly (chopping off 1 pixel).

Tested on 100% DPI and 125% DPI

Fixes #13349

Auditors: @srirambv, @petemill
@bsclifton
Copy link
Member

Problem worked around by updating the viewport size. Fix in commit 9a6ca8b

@srirambv
Copy link
Collaborator Author

Verified on 125%, 150% and looks fine

bsclifton added a commit that referenced this issue Mar 16, 2018
@bsclifton
Resize viewport associated with SVGs to 11x11. For some reason, DPI >…
298f8ab 
… 100% was not scaling these properly (chopping off 1 pixel).

Tested on 100% DPI and 125% DPI

Fixes #13349

Auditors: @srirambv, @petemill
bsclifton added a commit that referenced this issue Mar 16, 2018
@bsclifton
Resize viewport associated with SVGs to 11x11. For some reason, DPI >…
6848aa0 
… 100% was not scaling these properly (chopping off 1 pixel).

Tested on 100% DPI and 125% DPI

Fixes #13349

Auditors: @srirambv, @petemill
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
0.21.x issue first seen in 0.21.x misc/button OS/Windows QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.21.x w/ Chromium 65 (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @ltilve @bsclifton @srirambv @LaurenWags