Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmark text spills out of folder drop down on bookmark toolbar #13373

Closed
LaurenWags opened this issue Mar 2, 2018 · 8 comments
Closed

bookmark text spills out of folder drop down on bookmark toolbar #13373

LaurenWags opened this issue Mar 2, 2018 · 8 comments
Assignees
@cezaraugusto @bsclifton
Labels
0.21.x issue first seen in 0.21.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.21.x w/ Chromiu...

Comments

@LaurenWags
Copy link
Member

Description

Bookmark text is spilling out of the drop down (to the right) when you display the bookmarks in a folder on the toolbar.

Steps to Reproduce

  1. Have a folder on the bookmarks toolbar.
  2. Add some bookmarks to it that have long names.

Actual result:
Bookmark text spills over to the right.
screen shot 2018-03-02 at 1 08 28 pm

Expected result:
Bookmark text should not spill out:
screen shot 2018-03-02 at 1 17 03 pm

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.21.654
V8 | 6.5.254.26
rev | bc6272c
Muon | 5.1.3
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 65.0.3325.88

Reproducible on current live release:
No, does not reproduce on 0.21.18

Additional Information

Reproduced by @btlechowski on Windows.

Also occurs on sub folders:
screen shot 2018-03-02 at 1 28 11 pm
@LaurenWags LaurenWags added bug feature/bookmarks 0.21.x issue first seen in 0.21.x labels Mar 2, 2018
@LaurenWags LaurenWags added this to the 0.21.x w/ Chromium 65 (Beta Channel) milestone Mar 2, 2018
@bsclifton
Copy link
Member

Possibly related to #13371

@MargarytaChepiga
Copy link
Contributor

I would love to tackle this!

@MargarytaChepiga
Copy link
Contributor

MargarytaChepiga commented Mar 9, 2018 •
edited
Loading

Can't really reproduce though...
issue-13373-before
Edit: Sorry, just noticed that it is already mentioned that it is not reproducible on the current release.

@bsclifton
Copy link
Member

bsclifton commented Mar 9, 2018 •
edited by NejcZdovc
Loading

@MargarytaChepiga this is specific to Chromium 65- you should be able to reproduce by checking out / rebuilding from the 0.21.x-C65 branch. Unfortunately, the change is likely in Muon

@bsclifton
Copy link
Member

Assigning to @ltilve - he was unable to reproduce on Linux, so this may not be related to #13371

@bsclifton bsclifton mentioned this issue Mar 12, 2018
Closed
@darkdh darkdh mentioned this issue Mar 12, 2018
Closed
@darkdh darkdh self-assigned this Mar 12, 2018
@bsclifton bsclifton assigned bsclifton and unassigned darkdh and ltilve Mar 12, 2018
bsclifton added a commit that referenced this issue Mar 13, 2018
@bsclifton
Adjust context menu width so that it properly fits child content
c26216f 
Removes CSS variable introduced with 0dcaedb which is no longer used

Fixes #13373

Auditors: @cezaraugusto
@bsclifton
Copy link
Member

Fixed with c26216f

@bsclifton
Copy link
Member

bsclifton commented Mar 13, 2018 •
edited
Loading

Per conversation in c26216f, the problem is not fixed actually

Will need some help fixing this up

@bsclifton bsclifton reopened this Mar 13, 2018
cezaraugusto added a commit that referenced this issue Mar 13, 2018
@cezaraugusto
make bookmarked item content respect parent's contextMenu size
9eb635c 
-
this changes bookmark contextMenu from table to block element
fix #13373
cezaraugusto added a commit that referenced this issue Mar 13, 2018
@cezaraugusto
make bookmarked item content respect parent's contextMenu size
4ce5d61 
-
this changes bookmark contextMenu from table to block element
fix #13373
cezaraugusto added a commit that referenced this issue Mar 13, 2018
@cezaraugusto
make bookmarked item content respect parent's contextMenu size
a375135 
-
fix #13373
cezaraugusto added a commit that referenced this issue Mar 13, 2018
@cezaraugusto
make bookmarked item content respect parent's contextMenu size
886ae68 
-
fix #13373
bsclifton pushed a commit that referenced this issue Mar 13, 2018
@cezaraugusto @bsclifton
make bookmarked item content respect parent's contextMenu size
0d38e87 
-
fix #13373
@bsclifton
Copy link
Member

bsclifton commented Mar 13, 2018 •
edited
Loading

Properly fixed in 0.21.x-C65 with be4ee3e (huge thanks to @cezaraugusto!)

bsclifton pushed a commit that referenced this issue Mar 13, 2018
@cezaraugusto @bsclifton
make bookmarked item content respect parent's contextMenu size
be4ee3e 
-
fix #13373
bsclifton pushed a commit that referenced this issue Mar 16, 2018
@cezaraugusto @bsclifton
make bookmarked item content respect parent's contextMenu size
5ed8630 
-
fix #13373
cezaraugusto added a commit that referenced this issue Mar 20, 2018
@cezaraugusto
make bookmarked item content respect parent's contextMenu size
9e2a9a0 
-
this is the master branch fix for #13373
cezaraugusto added a commit that referenced this issue Mar 20, 2018
@cezaraugusto
make bookmarked item content respect parent's contextMenu size
e1747f4 
-
this is the master branch fix for #13373
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

@bsclifton bsclifton

Labels
0.21.x issue first seen in 0.21.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.21.x w/ Chromium 65 (Release Channel)
Development

No branches or pull requests
9 participants
@kjozwiak @ltilve @cezaraugusto @bsclifton @darkdh @MargarytaChepiga @srirambv @LaurenWags @btlechowski