Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Translations broken on beta channel #13499

Closed
srirambv opened this issue Mar 19, 2018 · 4 comments · Fixed by #13501
Closed

Translations broken on beta channel #13499

srirambv opened this issue Mar 19, 2018 · 4 comments · Fixed by #13501
Assignees
@diracdeltas
Labels
0.22.x issue first seen in 0.22.x bug l10n QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@srirambv
Copy link
Collaborator

Description

Translations broken on beta channel

Steps to Reproduce

  1. Upgrade to 0.22.5
  2. Open preferences page, none of the text is translated but instead shows the variable names

Actual result:
image

Expected result:
Text should be translated

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.5
V8 6.4.388.45
rev 94d33ff
Muon 5.0.7
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.167

Reproducible on current live release:
No

Additional Information

cc: @bsclifton
@srirambv srirambv added bug l10n release/blocking 0.22.x issue first seen in 0.22.x labels Mar 19, 2018
@srirambv srirambv added this to the 0.22.x (Beta Channel) milestone Mar 19, 2018
@bsclifton
Copy link
Member

Commit that broke this: e62e1ec

diracdeltas added a commit that referenced this issue Mar 19, 2018
@diracdeltas
Allow 'self' CSP connect-src by default
fdef11e 
fix #13499
@diracdeltas diracdeltas mentioned this issue Mar 19, 2018
Merged
10 tasks
@bsclifton bsclifton modified the milestones: 0.22.x (Beta Channel), 0.21.x w/ Chromium 65 (Release Channel) Mar 19, 2018
@eljuno
Copy link
Contributor

eljuno commented Mar 19, 2018 •
edited
Loading

Also happened on Brave 0.21.21 with English.

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Release Channel), 0.22.x (Beta Channel) Mar 19, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x because we reverted #13115 from 0.21.x

This was referenced Mar 22, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Linux

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
0.22.x issue first seen in 0.22.x bug l10n QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Allow 'self' CSP connect-src by default brave/browser-laptop
6 participants
@diracdeltas @bsclifton @srirambv @eljuno @LaurenWags @btlechowski