Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow 'self' CSP connect-src by default #13501

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Allow 'self' CSP connect-src by default #13501

merged 2 commits into from
Mar 19, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 19, 2018

fix #13499

test plan:

  1. do a packaged build
  2. translations should work in it
  3. translations should also work in development mode

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.22.x (Beta Channel) milestone Mar 19, 2018
@bsclifton bsclifton modified the milestones: 0.22.x (Beta Channel), 0.21.x w/ Chromium 65 (Release Channel) Mar 19, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With latest commit, both running locally and running packaged build works great! 😄 👍 Thanks!

@bsclifton bsclifton merged commit 5f796c8 into master Mar 19, 2018
@bsclifton bsclifton deleted the fix/13499 branch March 19, 2018 18:46
bsclifton added a commit that referenced this pull request Mar 19, 2018
Allow 'self' CSP connect-src by default
@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Release Channel), 0.22.x (Beta Channel) Mar 19, 2018
bsclifton added a commit that referenced this pull request Mar 19, 2018
Allow 'self' CSP connect-src by default
@bsclifton
Copy link
Member

master 5f796c8
0.23.x 33c3e84
0.22.x 47bce70

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations broken on beta channel
2 participants