Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

formatting is off on the corrupted wallet overlay #13582

Closed
LaurenWags opened this issue Mar 23, 2018 · 2 comments
Closed

formatting is off on the corrupted wallet overlay #13582

LaurenWags opened this issue Mar 23, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 23, 2018 •
edited by bsclifton
Loading

Description

Formatting is off on the corrupted wallet overlay. The FAQ link and the recover button should be on the same line.

Test plan / Steps to Reproduce

  1. Launch Brave from terminal with LEDGER_ENVIRONMENT=staging and LEDGER_VERBOSE=true with a clean profile
  2. enable payments
  3. close browser
  4. open ledger-state.json and modify seed (remove some of them)
  5. start browser again with same parameters
  6. navigate to payments

Actual result:
screen shot 2018-03-23 at 11 57 30 am

Expected result:
From #13424 (comment)
proposedwalletoverlay

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.7

Reproducible on current live release:
no

Additional Information

cc @NejcZdovc @bradleyrichter
@LaurenWags LaurenWags added this to the 0.22.x (Beta Channel) milestone Mar 23, 2018
@LaurenWags LaurenWags mentioned this issue Mar 23, 2018
Closed
@NejcZdovc NejcZdovc self-assigned this Mar 26, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 26, 2018
@NejcZdovc
Fixes overlay for corrupted wallet
4538cb3 
Resolves brave#13582

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Mar 26, 2018
Merged
10 tasks
bsclifton added a commit that referenced this issue Mar 26, 2018
@bsclifton
Merge pull request #13605 from NejcZdovc/hotfix/#13582-css
e942b30 
Fixes overlay for corrupted wallet
@bsclifton
Copy link
Member

Fixed with #13605

This was referenced Mar 28, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 28, 2018 •
edited by kjozwiak
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.9 e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Win7 x64:

  • 0.22.9: e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Ubuntu 17.10 x64 using the following build:

  • 0.22.9 e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @LaurenWags @btlechowski