This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
time reporting for twitch isn't accurate #13828
Labels
Milestone
Comments
@NejcZdovc is this due to Twitch changing their API again? We had #13597 which was fixed in |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 16, 2018
Resolves brave#13828 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 16, 2018
Resolves brave#13828 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 16, 2018
Resolves brave#13828 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 16, 2018
Resolves brave#13828 Auditors: Test Plan:
NejcZdovc
modified the milestones:
0.22.x Release 3 (Beta channel),
0.22.x w/ Chromium 66
Apr 17, 2018
This was referenced Apr 19, 2018
This was referenced Apr 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Twitch videos/publishers used to be added to the ledger table right away with a time spent of 10s. Now they're not being added until a minute or 2 into the video/stream. This means that time reporting is no longer accurate. Also, when running LEDGER_VERBOSE=true, I'm seeing a syntax error.
Steps to Reproduce
Actual result:
Twitch channel will eventually be added to the table, but the time on the ledger does not match the time spent on Twitch.
Expected result:
Reproduces how often:
easily
Brave Version
about:brave info:
0.22.19
Reproducible on current live release:
yes, reproduces on 0.22.13
Additional Information
Syntax errors from terminal: https://gist.github.com/LaurenWags/f3c719367acc0486002995ae3ae1041c#file-twitch_syntax2-json
Time (eventually) logged by ledger was 3m 60s:
But video was actually 5m 10s:
The text was updated successfully, but these errors were encountered: