Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

time reporting for twitch isn't accurate #13828

Closed
LaurenWags opened this issue Apr 13, 2018 · 2 comments
Closed

time reporting for twitch isn't accurate #13828

LaurenWags opened this issue Apr 13, 2018 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Twitch videos/publishers used to be added to the ledger table right away with a time spent of 10s. Now they're not being added until a minute or 2 into the video/stream. This means that time reporting is no longer accurate. Also, when running LEDGER_VERBOSE=true, I'm seeing a syntax error.

Steps to Reproduce

  1. Clean profile on 0.22.19, launch Brave with LEDGER_VERBOSE=true
  2. Enable payments.
  3. Navigate to a Twitch video/stream and start it if necessary.
  4. Switch back to ledger --> video is not listed in ledger table with time spent of 10s
  5. Look at terminal --> syntax error in terminal
  6. Continue to watch the video/stream for a few minutes

Actual result:
Twitch channel will eventually be added to the table, but the time on the ledger does not match the time spent on Twitch.

Expected result:

  1. Video/stream should be added to the ledger table immediately with a time spent of 10s
  2. no syntax error in terminal
  3. Time spent on twitch video/stream should be accurate

Reproduces how often:
easily

Brave Version

about:brave info:
0.22.19

Reproducible on current live release:
yes, reproduces on 0.22.13

Additional Information

Syntax errors from terminal: https://gist.github.com/LaurenWags/f3c719367acc0486002995ae3ae1041c#file-twitch_syntax2-json

Time (eventually) logged by ledger was 3m 60s:
screen shot 2018-04-13 at 10 57 44 am

But video was actually 5m 10s:
screen shot 2018-04-13 at 10 58 12 am

@LaurenWags LaurenWags added this to the 0.22.x Release 3 (Beta channel) milestone Apr 13, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2018

@NejcZdovc is this due to Twitch changing their API again? We had #13597 which was fixed in 0.22.13 and tested. I'm assuming we would have caught this if it was present at the time as Twitch was tested pretty well as it included several fixes that needed verification. Seems like this is really easy to reproduce as well.

@NejcZdovc NejcZdovc self-assigned this Apr 16, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 16, 2018
Resolves brave#13828

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 16, 2018
Resolves brave#13828

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 16, 2018
Resolves brave#13828

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 16, 2018
Resolves brave#13828

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.22.x Release 3 (Beta channel), 0.22.x w/ Chromium 66 Apr 17, 2018
NejcZdovc added a commit that referenced this issue Apr 18, 2018
NejcZdovc added a commit that referenced this issue Apr 18, 2018
NejcZdovc added a commit that referenced this issue Apr 18, 2018
NejcZdovc added a commit that referenced this issue Apr 18, 2018
@btlechowski
Copy link
Contributor

btlechowski commented Apr 19, 2018

Verified Ubuntu 17.10

  • Version 0.22.664
  • Muon 5.2.4

Verified on macOS 10.12.6 with

  • 0.22.664 a98bd86
  • Muon 5.2.4
  • libchromiumcontent 66.0.3359.117

Verified on Win 10 x64 using the following build:

  • 0.22.665 rev: bc13ab6
  • Muon: 5.2.5
  • libchromiumcontent: 66.0.3359.117

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.