-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13834 +/- ##
==========================================
+ Coverage 56.52% 56.61% +0.08%
==========================================
Files 283 283
Lines 28817 28848 +31
Branches 4777 4782 +5
==========================================
+ Hits 16289 16331 +42
+ Misses 12528 12517 -11
|
7c32d2d
to
d6bcd6e
Compare
Resolves brave#13828 Auditors: Test Plan:
d6bcd6e
to
1c19218
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test plan works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NejcZdovc I'm seeing errors spammed to the console:
[40142:32003:0417/143759.495127:ERROR:upload_data_presenter.cc(73)] Not implemented reached in virtual void extensions::RawDataPresenter::FeedNext(const net::UploadElementReader &)
@jasonrsadler not sure what this is, but i think is not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I does it on master as well. Everything else looks good
that is not related to the changes of this PR. |
0.22.x-c66 f39f6d2 |
Resolves #13828
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests