This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Brave does not open hyperlinks if there aren't any windows open #13859
Assignees
Labels
0.22.x
issue first seen in 0.22.x
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
regression
release-notes/include
Milestone
Comments
LaurenWags
added
OS/macOS
regression
release-notes/include
0.22.x
petemill
added a commit
that referenced
this issue
Apr 19, 2018
…cused Fix #13859 Fix #13860 Fix #13865 Makes sure tabs are created in a shown window, or creates a new window, that the window is focused, and if the shown window is minimized, then that window is restored. Fixes for the following scenarios...: - There are no windows open - There are only minimized windows open ...For the following actions: - Brave is default browser and link clicked in another application - macOS dock icon is clicked - 'Brave' menu actions such as 'New Tab' or 'About Brave' Test plan: Browser must be set as default. If testing from source, the best way is to create a build `CHANNEL=dev npm run build-package`, run that, and set it as default. - Click URL link in external application - Ensure that tab opens in an active window, and the window is focused with the following scenarios: - 1 window open - 2+ windows open - 0 windows open - 1 minimized window open - 1 minimized window open and 1 non-minimized window open - Application exited - macOS: click dock icon, ensure window is focused or created: - 1 window open - 2+ windows open - 0 windows open - 1 minimized window open - 1 minimized window open and 1 non-minimized Even though the reported issues were macOS only, this test plan should be carried out on other platforms to ensure no regressions.
10 tasks
|
Removed macOS label - linked test plan was recommended to be checked on all platforms. |
This was referenced Apr 23, 2018
|
Thanks for fixing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test Plan
#13866
Also follow STR below if applicable for your platform.
Description
When Brave is set as your default browser and it is running, but there aren't any open windows, if you click on a hyperlink the hyperlink does not open. This makes it look like Brave doesn't work.
Reported via community: https://community.brave.com/t/updating-macos-from-0-22-13-to-0-22-21/19915/7
Steps to Reproduce
Actual result:
Hyperlink does not open. Workaround: Navigate to File > New Window or right click on the icon in the dock and select New Window. New window displays with two tabs: a new one and the hyperlink you selected is the 2nd tab within the new window.
Expected result:
Hyperlink should open.
Reproduces how often:
Easily
Brave Version
about:brave info:
0.22.22
Reproducible on current live release:
Yes, was last working in 0.21.24 and stopped working in 0.22.13
Additional Information
Seems like maybe it could be related to #13689 but the fix for this one does not resolve the reported issue (checked with 0.22.109)
After this is resolved, should also verify that this works with Brave open or closed, windows open or no windows open.
The text was updated successfully, but these errors were encountered: