This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Brave menu items which open tabs do so in minimized window #13865
Assignees
Labels
Milestone
Comments
petemill
added a commit
that referenced
this issue
Apr 19, 2018
…cused Fix #13859 Fix #13860 Fix #13865 Makes sure tabs are created in a shown window, or creates a new window, that the window is focused, and if the shown window is minimized, then that window is restored. Fixes for the following scenarios...: - There are no windows open - There are only minimized windows open ...For the following actions: - Brave is default browser and link clicked in another application - macOS dock icon is clicked - 'Brave' menu actions such as 'New Tab' or 'About Brave' Test plan: Browser must be set as default. If testing from source, the best way is to create a build `CHANNEL=dev npm run build-package`, run that, and set it as default. - Click URL link in external application - Ensure that tab opens in an active window, and the window is focused with the following scenarios: - 1 window open - 2+ windows open - 0 windows open - 1 minimized window open - 1 minimized window open and 1 non-minimized window open - Application exited - macOS: click dock icon, ensure window is focused or created: - 1 window open - 2+ windows open - 0 windows open - 1 minimized window open - 1 minimized window open and 1 non-minimized Even though the reported issues were macOS only, this test plan should be carried out on other platforms to ensure no regressions.
10 tasks
|
Removed macOS label - linked test plan was recommended to be checked on all platforms. |
This was referenced Apr 23, 2018
This was referenced Apr 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test Plan
#13866
Also follow STR below if applicable for your platform.
Description
Brave menu items will open a tab in a minimized window, but will not show that window, making it seem like nothing has happened.
Steps to Reproduce
Actual result:
Nothing happens (the tabs are created in the minimized window)
Expected result:
The window that the tabs are created in is restored and focused
Reproduces how often:
100%
Brave Version
about:brave info:
0.22.22
Reproducible on current live release:
Yes, and 0.21.x (and before most likely)
Additional Information
This was fixed as a result of the fix for #13859 and #13860
The text was updated successfully, but these errors were encountered: