This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
URL Heart (publisher toggle) button should be able to include sites outside of minimum requirements #13879
Labels
Milestone
Test Plan
#13913
Description
Previously discussed with @NejcZdovc & @bsclifton, related to: #12675
Currently, the publisher toggle button in the navigation bar (heart) functions only as an inclusion toggle, that is:
It does not add a site to the ledger if it is not already in it, it only can pin and unpin sites that are already in the ledger.
The suggestion is that it is able to include sites from the ledger entirely. For example:
Navigating to news.ycombinator.com, with minimum inclusion times set 1 minute long with 5 visits, a user should be able after only a few seconds have passed, to click the publisher toggle and see ycombinator.com in the ledger 5 minutes total time, and 5 visits.
From that point on, the publisher toggle will then retain its current functionality of acting as a pinned state toggle. Users should navigate to about:preferences#payments if they wish to remove the site from payments.
It seems natural that this button drives control of what the user would like to see in the ledger.
Additional Information
Currently the button has three states, the language of them here:
cc: @bradleyrichter for feedback about the issue in general, as well as the new language for the hover states
Note: This has a cross dependency with #13856
The code for a manual addition outside of set minimum requirements will need to be leveraged for this feature
If viewing this functionality is desired, it can be viewed in this branch (This would be rebased with #13856 once it gets merged)
The text was updated successfully, but these errors were encountered: