Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

some sites aren't being added to payments after meeting minimum criteria #14085

Closed
LaurenWags opened this issue May 10, 2018 · 5 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 10, 2018

Description

Some sites aren't being added to the ledger table after the visit meets minimum criteria. An example is https://miaou.art

Reported via community: https://community.brave.com/t/publisher-is-not-yet-added-to-the-ledger-because-it-doesnt-meet-criteria-yet/21831

Steps to Reproduce

  1. Enable Payments
  2. Navigate to https://miaou.art
  3. Wait until at least minimum criteria is met.
  4. Navigate back to Payments.

Actual result:
Site is not included in the ledger table. If you go back to https://miaou.art and hover over the URL icon you see this:

screen shot 2018-05-10 at 9 36 05 am

Expected result:
Site should be added to payments table after minimum criteria is met.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.669

Reproducible on current live release:
Yes

Additional Information

Seems like #12675. See #14085 (comment).

@LaurenWags
Copy link
Member Author

Note - this site can be manually added to the ledger table using 0.22.703 (due to #13879) but the site still isn't added automatically to the ledger table.

@ryanml
Copy link
Contributor

ryanml commented May 10, 2018

@LaurenWags curious, are you able to repro this on 0.24.0 ? I am not able to. Just want to determine if it may have been fixed recently.

@LaurenWags
Copy link
Member Author

LaurenWags commented May 11, 2018

@ryanml just checked and I cannot reproduce this when building from master 😄
Update - also tried latest Developer build (0.23.4) and issue reproduces there.

@srirambv
Copy link
Collaborator

srirambv commented Jun 1, 2018

https://www.dbs.com.sg/treasures/aics/pdfController.page?pdfpath=/content/article/pdf/AIO/AIO_2016/SECTOR-19-001-blockchain-lowres.pdf doesn't get added even after staying on the page for 4 mins. However if i just visit the domain page it gets added to the ledger table.

@jasonrsadler
Copy link
Contributor

jasonrsadler commented Jun 12, 2018

miaou.art is using a css file from https://www.sharebutton.co/fonts/v2/entypo.min.css. The sharebutton site is using an expired certificate from a totally different site and causes resource load failures on page load in miaou.art. Not sure if that would contribute to the ledger add problem but an FYI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants