Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL Heart (include for payment) button disabled even after time requirements satisfied #12675

Closed
bradleyrichter opened this issue Jan 17, 2018 · 3 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 17, 2018

Test plan

  1. Enable payments
  2. Visit a site in a new tab and keep focus on the page
  3. Ensure the page is included in ledger when the min time requirement is satisfied

image

image

site:
https://www.theguardian.com/cities/2018/jan/16/beginning-end-trump-real-estate-empire

@NejcZdovc
Copy link
Contributor

@bsclifton what is the status of this one?

@bsclifton
Copy link
Member

bsclifton commented Mar 9, 2018

@NejcZdovc when @ryanml and I met, we found a clear way to force the update to happen. The way we triggered the update was by doing the same action which happens on window blur:

state = ledgerApi.pageDataChanged(state, {}, true)

However, there didn't seem to be a good event or interval that we could force this update to happen on. Unless we use setTimeout or setInterval to perform a check (which could get messy and cause performance issues), it would be hard to be exact (without lots of overhead).

I think it would be great to talk about next steps on this together 😄

@NejcZdovc NejcZdovc added the needs-discussion A suggestion that lacks agreement from the team. label Apr 4, 2018
@NejcZdovc NejcZdovc removed their assignment Apr 9, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Apr 26, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Apr 26, 2018
@NejcZdovc NejcZdovc removed PR/pending-review needs-discussion A suggestion that lacks agreement from the team. labels Apr 26, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Apr 26, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Apr 26, 2018
NejcZdovc pushed a commit to ryanml/browser-laptop that referenced this issue Apr 27, 2018
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone Apr 27, 2018
@LaurenWags
Copy link
Member

LaurenWags commented May 3, 2018

Verified with macOS 10.12.6 using

  • 0.22.702 e4a853d
  • muon 6.0.7
  • libchromiumcontent 66.0.3359.139

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.