Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

TypeError: Error processing argument at index 0, conversion failure from undefined when using Mute other tabs with large profiles #14058

Closed
kjozwiak opened this issue May 8, 2018 · 1 comment

Comments

@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2018

Description

When attempting to Mute other tabs when you have a large profile, the browser will become unresponsive for ~1min and will spam the following error via the terminal:

TypeError: Error processing argument at index 0, conversion failure from undefined
    at Object.setAudioMuted (/Applications/Brave-Beta.app/Contents/Resources/app.asar/app/browser/tabs.js:933:11)
    at Immediate.setImmediate (/Applications/Brave-Beta.app/Contents/Resources/app.asar/app/browser/reducers/tabsReducer.js:361:16)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate (timers.js:617:5)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

However, running through the above case with 0.22.669 requires a force quit as the entire browser becomes unresponsive and never seems to recover.

Steps to Reproduce

  1. launch 0.22.669 or 0.22.703
  2. replace session-store-1 with a profile from https://www.dropbox.com/sh/9sstz62vj41comg/AAD6fnZctgLlFfOXRzuQDWDla?dl=0
  3. once you've launched the profile, right click on a random tab and select Mute other tabs

Actual result:

muteissue

Expected result:

It shouldn't be spamming the terminal with the above errors and Brave shouln't become unresponsive even though it ends up recovering.

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.22.703 
V8: 6.6.346.26 
rev: 903b8d0d3703b5fdc5a719294403e7460d9b806d 
Muon: 6.0.8 
OS Release: 17.4.0 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 66.0.3359.139

Reproducible on current live release:

Yes, currently reproducible under 0.22.669 which is the latest released version.

Additional Information

@kjozwiak kjozwiak added the bug label May 8, 2018
@kjozwiak kjozwiak added this to the Triage Backlog milestone May 8, 2018
petemill added a commit that referenced this issue May 8, 2018
Muon will crash if receiving a value that is not of the expected type, including `undefined`.
Optimize which frames are sent from window to browser for muting.
Fix #14058

Test plan:
Directly affected by code changes:
- Tab's context-menu: mute all tabs
- Tab Page Indicator context menu: mute all tabs
- Tab Page Indicator context menu: unmute all tabs
Regression tests:
- Tab audio indicator: mute
- Tab audio indicator: unmute
@petemill petemill modified the milestones: Triage Backlog, 0.22.x Release 3 (Beta channel) May 8, 2018
@petemill petemill self-assigned this May 8, 2018
@LaurenWags
Copy link
Member

LaurenWags commented May 10, 2018

Verified with macOS 10.12.6 using

  • 0.22.706 e11b027
  • muon 6.0.9
  • libchromiumcontent 66.0.3359.139

Verified on Windows x64

  • 0.22.706 e11b027
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.9

Verified on Ubuntu 17.10 x64

  • 0.22.706 e11b027
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.