Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ensure type-safety with tab audio muting #14061

Merged
merged 1 commit into from
May 8, 2018
Merged

Conversation

petemill
Copy link
Member

@petemill petemill commented May 8, 2018

Fix #14058

Muon will error if receiving a value that is not of the expected type, including undefined.
Optimize which frames are sent from window to browser for muting.

Test plan:

Directly affected by code changes:

  • Tab's context-menu: mute all tabs
  • Tab Page Indicator context menu: mute all tabs
  • Tab Page Indicator context menu: unmute all tabs

Regression tests:

  • Tab audio indicator: mute
  • Tab audio indicator: unmute

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added this to the 0.22.x Release 3 (Beta channel) milestone May 8, 2018
@petemill petemill self-assigned this May 8, 2018
@petemill petemill requested a review from bsclifton May 8, 2018 20:11
Muon will crash if receiving a value that is not of the expected type, including `undefined`.
Optimize which frames are sent from window to browser for muting.
Fix #14058

Test plan:
Directly affected by code changes:
- Tab's context-menu: mute all tabs
- Tab Page Indicator context menu: mute all tabs
- Tab Page Indicator context menu: unmute all tabs
Regression tests:
- Tab audio indicator: mute
- Tab audio indicator: unmute
@petemill petemill force-pushed the fix/14058-crash-mute-tabs branch from 6be78c2 to 3dc6934 Compare May 8, 2018 20:13
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good- manually tested and it works great 😄 👍

@bsclifton bsclifton merged commit 917c479 into master May 8, 2018
@bsclifton bsclifton deleted the fix/14058-crash-mute-tabs branch May 8, 2018 20:33
bsclifton added a commit that referenced this pull request May 8, 2018
Ensure type-safety with tab audio muting
bsclifton added a commit that referenced this pull request May 8, 2018
Ensure type-safety with tab audio muting
@bsclifton
Copy link
Member

master 917c479
0.23.x d9e1f04
0.22.x-release3 e19b5c4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants