Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

http link gets added as https in ledger table #14283

Closed
srirambv opened this issue May 30, 2018 · 4 comments
Closed

http link gets added as https in ledger table #14283

srirambv opened this issue May 30, 2018 · 4 comments
Assignees
@ryanml
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x w/ Chromiu...

Comments

@srirambv
Copy link
Collaborator

Description

http link gets added as https in ledger table

Steps to Reproduce

  1. Clean install 0.22.723
  2. Visit a http site (for exp: http://espn.com/)
  3. Stay on the page for min 8sec to meet min time criteria
  4. Open payments, ensure site is listed in ledger table
  5. Close tab from step 3
  6. Click on ESPN link from ledger table, opens https://espn.com/ which fails to load and only works on http

Actual result:
https-http

Expected result:
Should not make http links as https

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.723
V8 6.6.346.32
rev edb3e88
Muon 6.0.12
OS Release 10.0.17134
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.170

Reproducible on current live release:
Yes

Additional Information
@btlechowski
Copy link
Contributor

Reproduced on Ubuntu 17.10 v 0.22.723

ryanml added a commit to ryanml/browser-laptop that referenced this issue May 30, 2018
@ryanml
Fixes brave#14283, ensuring http only links are added as such in the …
9591f9e 
…ledger table
@ryanml ryanml mentioned this issue May 30, 2018
Merged
10 tasks
@ryanml ryanml self-assigned this May 30, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue May 31, 2018
@ryanml
Fixes brave#14283, ensuring http only links are added as such in the …
a237603 
…ledger table
ryanml added a commit to ryanml/browser-laptop that referenced this issue May 31, 2018
@ryanml
Fixes brave#14283, ensuring http only links are added as such in the …
bce1563 
…ledger table
@GeetaSarvadnya
Copy link
Collaborator

Issue persist on Brave beta 806 build. Hence reopening the issue.
http site from ledger redirect to https

@GeetaSarvadnya GeetaSarvadnya reopened this Jun 5, 2018
@bsclifton
Copy link
Member

bsclifton commented Jun 5, 2018 •
edited
Loading

I don't think this was included in a build (yet). Closing so we can re-test on a new build

This was referenced Jun 7, 2018
Closed
Closed
Closed
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 7, 2018 •
edited by LaurenWags
Loading

Verified on Windows 10 x64 with

  • 0.22.807 2d4f6e8
  • muon 7.0.4
  • libchromiumcontent 67.0.3396.71

Verified on Ubuntu 17.10 x64

  • 0.22.807 2d4f6e8
  • muon 7.0.4
  • libchromiumcontent 67.0.3396.71

Verified with macOS 10.12.6 using

  • 0.22.807 2d4f6e8
  • Muon 7.0.4
  • libchromiumcontent 67.0.3396.71

@kjozwiak kjozwiak mentioned this issue Jun 11, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x w/ Chromium 67 (Release Channel)
Development

No branches or pull requests
7 participants
@kjozwiak @bsclifton @ryanml @srirambv @LaurenWags @btlechowski @GeetaSarvadnya