Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ensuring http only sites are not added as https in the ledger table #14289

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 30, 2018

Fixes: #14283

The publisher's protocol was not being set early enough (it was not being done until the favicon was fetched), thus it was being placed in to the ledger table with https: as the default.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Install Brave, enable payments
  2. Visit a http site (for exp: http://espn.com/)
  3. Stay on the page for min 8sec to meet min time criteria
  4. Open payments, ensure site is listed in ledger table
  5. Click on ESPN link, ensure that link directs to http://espn.com properly
  6. Ensure that this strategy works when clicking on the publisher toggle when criteria is not met (http://www.nossl.net/)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@ryanml ryanml self-assigned this May 30, 2018
@ryanml ryanml requested a review from jasonrsadler May 30, 2018 23:25
@NejcZdovc NejcZdovc self-requested a review May 31, 2018 06:40
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanml is this ready for review? The issue still exists.

@ryanml
Copy link
Contributor Author

ryanml commented May 31, 2018

Repro'd with STR provided in Slack, moving back to WIP

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Works great! 🏆

@NejcZdovc NejcZdovc added this to the Completed work milestone Jun 4, 2018
@bsclifton bsclifton modified the milestones: Completed work, 0.22.x w/ Chromium 67 (BETA Channel) Jun 4, 2018
@bsclifton bsclifton merged commit 341cb7e into brave:master Jun 4, 2018
bsclifton added a commit that referenced this pull request Jun 4, 2018
Ensuring http only sites are not added as https in the ledger table
bsclifton added a commit that referenced this pull request Jun 4, 2018
Ensuring http only sites are not added as https in the ledger table
@bsclifton
Copy link
Member

master 341cb7e
0.23.x d287db8
0.22.x be0d0c2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants