This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Private tab doesn't allow torrent download #14524
Assignees
Labels
Milestone
Comments
diracdeltas
added a commit
that referenced
this issue
Jun 22, 2018
* re-enable webtorrent in private tabs * stop page loading indicator after torrent warning is shown in a tor tab fix #14472 fix #14524 Test Plan: 1. open brave and make sure webtorrent is enabled 2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab. it should load webtorrent. 3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it should show a privacy warning. 4. click 'ok'. the page loading indicator should stop.
10 tasks
|
Fixed with #14529 |
bsclifton
pushed a commit
that referenced
this issue
Jun 23, 2018
* re-enable webtorrent in private tabs * stop page loading indicator after torrent warning is shown in a tor tab fix #14472 fix #14524 Test Plan: 1. open brave and make sure webtorrent is enabled 2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab. it should load webtorrent. 3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it should show a privacy warning. 4. click 'ok'. the page loading indicator should stop.
This was referenced Jun 25, 2018
bsclifton
pushed a commit
that referenced
this issue
Jun 25, 2018
* re-enable webtorrent in private tabs * stop page loading indicator after torrent warning is shown in a tor tab fix #14472 fix #14524 Test Plan: 1. open brave and make sure webtorrent is enabled 2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab. it should load webtorrent. 3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it should show a privacy warning. 4. click 'ok'. the page loading indicator should stop.
bsclifton
pushed a commit
that referenced
this issue
Jun 26, 2018
* re-enable webtorrent in private tabs * stop page loading indicator after torrent warning is shown in a tor tab fix #14472 fix #14524 Test Plan: 1. open brave and make sure webtorrent is enabled 2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab. it should load webtorrent. 3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it should show a privacy warning. 4. click 'ok'. the page loading indicator should stop.
bsclifton
pushed a commit
that referenced
this issue
Jun 27, 2018
* re-enable webtorrent in private tabs * stop page loading indicator after torrent warning is shown in a tor tab fix #14472 fix #14524 Test Plan: 1. open brave and make sure webtorrent is enabled 2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab. it should load webtorrent. 3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it should show a privacy warning. 4. click 'ok'. the page loading indicator should stop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
See #14529
Description
Private tab allows to download torrent
Steps to Reproduce
Actual result:
Private tab allows to download torrent
Expected result:
Should allow torrents to run in private tab or should show error similar to tor tab that it should not be allowed to run
Reproduces how often:
100%
Brave Version
about:brave info:
0.22.810 and 0.23.14
Reproducible on current live release:
Works on release but not on beta
Additional Information
The text was updated successfully, but these errors were encountered: