Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

fix tor-related webtorrent issues #14529

Merged
merged 1 commit into from
Jun 23, 2018
Merged

fix tor-related webtorrent issues #14529

merged 1 commit into from
Jun 23, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 22, 2018

  • re-enable webtorrent in private tabs
  • stop page loading indicator after torrent warning is shown in a tor
    tab

fix #14472
fix #14524

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. open brave and make sure webtorrent is enabled
  2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
    it should load webtorrent.
  3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
    should show a privacy warning.
  4. click 'ok'. the page loading indicator should stop.

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

* re-enable webtorrent in private tabs
* stop page loading indicator after torrent warning is shown in a tor
tab

fix #14472
fix #14524

Test Plan:
1. open brave and make sure webtorrent is enabled
2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
   it should load webtorrent.
3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
   should show a privacy warning.
4. click 'ok'. the page loading indicator should stop.
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan works great 😄👍

@bsclifton bsclifton merged commit 7777ff5 into tor/0.23.x Jun 23, 2018
@bsclifton bsclifton deleted the fix/tor-rent branch June 23, 2018 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants