Show menu by default on Windows and allow to turn it off

[bbondy]

A lot of times Windows users think we're missing functionality because there's no menu bar visible in Windows. Of course like in most Windows apps you can press Alt to show it, but a lot of users don't see that.

This task is to:
i) Show the menu bar by default on Windows
ii) Add another context menu item next to the Bookmarks Toolbar one for Menu Bar.

CC @bradleyrichter if he has objections.

Originally it was hidden by default because on Windows we have extra window chrome from the titlebar. Ideally we could get rid of that first bu this task would be a lot easier to do first.

[bbondy]

btw I'd still like us to have the on / off context menu even if we don't change the default.
Also you can change this autoHideMenuBar: true, in appStore.js.
CC @bsclifton in case he's interested in taking and tying this to a pref.

[bsclifton]

Should be a slam dunk- will check out later today

[bradleyrichter]

We need this. Too many support requests related to not finding the menu.

On May 1, 2016, at 8:00 AM, Brian R. Bondy notifications@github.com wrote:

A lot of times Windows users think we're missing functionality because there's no menu bar visible in Windows. Of course like in most Windows apps you can press Alt to show it, but a lot of users don't see that.

This task is to:
i) Show the menu bar by default on Windows
ii) Add another context menu item next to the Bookmarks Toolbar one for Menu Bar.

CC @bradleyrichter if he has objections.

Originally it was hidden by default because on Windows we have extra window chrome from the titlebar. Ideally we could get rid of that first bu this task would be a lot easier to do first.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[bsclifton]

Started to work on this...
https://github.com/bsclifton/browser-laptop/commit/97f789898b080933ecd88c4c0763b8b082a6805b

Requires a browser restart at the moment, trying to find a clean way to hook into electron::BrowserWindow#setMenuBarVisibility(visible) when the property changes

Should this change only be visible to Windows users? Or visible to all but only defaulted to show the menu on Windows?

[ghost]

Would make sense to make the hamburger menu disappear if the menu bar is shown. Would be nice if you would implement that.

[bradleyrichter]

I am a little concerned about things moving around when hiding the burger.

Before we add this hiding ability, let me look at how "those other browsers" deal with this issue.

Tx - Brad

On May 2, 2016, at 11:12 AM, SJ Diamond notifications@github.com wrote:

Would make sense to make the hamburger menu disappear if the menu bar is shown. Would be nice if you would implement that.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[bbondy]

I think the hamburger menu is still useful for ease of access for common things like zoom for example. If we're going to hide it I'd rather just have a second checkbox like the Show Home Button option.

[bsclifton]

Should be completely fixed by #1630

Ready for review 😄

[luixxiul]

Closing as this was already fixed.