about:preferences now has "autohide menu" option #1630
Conversation
| @@ -120,3 +120,4 @@ zoom=Zoom | |||
| new=New | |||
| learnSpelling=Learn Spelling | |||
| ignoreSpelling=Ignore Spelling | |||
| autoHideMenuBar=Hide the menu bar | |||
|
This is looking good but the main thing I see before this can be merged in is that there should be no option for this at all for OS X (process.platform === 'darwin') |
|
Good catch, thanks 😃 I'll tweak this PR to hide the preference (and the context menu) on OS X |
… the moment, setting only takes effect when launching browser (restart required on change).
…his first handler will show/hide the application menu.
…alse on Windows (will update in a following commit).
… click in bookmarks toolbar
…ault to true (hide the menu).
…failed to install when doing a fresh npm install.
…ing) - Don't show "hide menu bar" in bookmarks toolbar context menu for OS X - Always set autoHideMenuBar to true (when creating BrowserWindow) for OS X
|
Screenshots (NOTE: changes only show for Windows / Linux) New option in preferences (default is SHOW on Windows) New context menu item when right clicking on bookmarks toolbar |
|
Manually merged because of a conflict, thanks! |
|
On Ubuntu Hide Menu Bar seems to hide nothing. Is it only for Windows? |
|
I actually went back and forth about linux, does it not hide anything for all distros? I noticed the electron code only ignores OS X. |
|
Turning on that option does not hide the bookmark toolbar. Rather than that I'm not sure what it is supposed to do because it is unclear to me where the menu bar is. |
|
@luixxiul interesting... Is the menu in BrowserWindow a Windows only feature? It's supposed to hide this menu (see picture- the file, edit, view, etc) which is toggleable by hitting alt (at least on Windows) and hidden by default (before this PR- which sets it to shown for Windows by default): |
|
@bsclifton On Unity (Ubuntu) like this: Not sure about other desktop environments. |
|
ah- it seems at least with Ubuntu/Unity, the menu ALWAYS shows |
|
I'll post separate t fix for Ubuntu/Unity but probably not the highest priority. The option is respected and works properly in Dedbian with Gnome. |
Updates to resolve #1524
What is missing (will address in future PR):context menu item in the bookmarks toolbardefault this new option to "false", but only for Windows users