Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Question: Can you keep the ability of good font rendering? #2089

Closed
ghost opened this issue Jun 5, 2016 · 2 comments · Fixed by #6947
Closed

Question: Can you keep the ability of good font rendering? #2089

ghost opened this issue Jun 5, 2016 · 2 comments · Fixed by #6947

Comments

@ghost
Copy link

ghost commented Jun 5, 2016

Google removes in Chromium 52 the better font rendering with removing support to deactivate DirectWrite on their quest to remove the last supporting code for older operating systems.

Which will leave tons of people with bad font rendering. This will also affect Brave. Any hope that you can avoid that?

Links:

https://codereview.chromium.org/1919573002
and
https://bugs.chromium.org/p/chromium/issues/detail?id=579196

@bbondy
Copy link
Member

bbondy commented Jun 6, 2016

I don't think we allow to deactivate DirectWrite right now so I don't think there is a benefit to differentiate here right now.

bsclifton added a commit that referenced this issue Jan 31, 2017
…n Windows

This was originally added to fix #4517, #4518, and #4472... but is no longer needed (I confirmed all those situations work).

Fixes #6462
Fixes #6777
Fixes #6144
Fixes #3556
Fixes #2089

Auditors: @bridiver, @bbondy, @darkdh
@bsclifton
Copy link
Member

bsclifton commented Jan 31, 2017

I don't believe there is anything we can do to actually "fix" this (ex: keeping DirectWrite); that logic all lies in Chromium. But removing the enable-use-zoom-for-dsf flag will help ensure that text is crisp and readable, especially on higher DPI machines

Test plan

#6947 (comment)

bbondy pushed a commit that referenced this issue Jan 31, 2017
…n Windows

This was originally added to fix #4517, #4518, and #4472... but is no longer needed (I confirmed all those situations work).

Fixes #6462
Fixes #6777
Fixes #6144
Fixes #3556
Fixes #2089

Auditors: @bridiver, @bbondy, @darkdh
@luixxiul luixxiul added this to the 0.13.2 milestone Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants