Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

General Settings: "Brave is not your default browser" setting #2105

Closed
bradleyrichter opened this issue Jun 7, 2016 · 1 comment · Fixed by #4872
Closed

General Settings: "Brave is not your default browser" setting #2105

bradleyrichter opened this issue Jun 7, 2016 · 1 comment · Fixed by #4872

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jun 7, 2016

Functionality:
Button:
For each specific OS, the button may require a different action/script.

Mac OS - Utilize available API to toggle OS level setting, and show the standard dialog.
Dialog sample:
image

Windows: Either toggle the default browser setting and show the Windows standard confirmation dialog, or open the windows CP if the API is not available. (Win 7 vs 8 vs 10 for example)

Linux: Same as windows.

Switch:
"Always check on startup" is on by default, but may be switched off by the user.

Item label:
"Brave is not your default browser"

Button label:
"Set as default..."

Switch label:
"Always check on startup"

Settings window:
image

Startup Sheet Dialog: (slides down from below tabs toolbar)
image

And setting toggle state: (when Brave is your default browser)

The button hides and the "startup check" switch moves up.
image

@bradleyrichter bradleyrichter added this to the 0.11.0dev milestone Jun 7, 2016
@bbondy bbondy modified the milestone: 0.11.1dev Jul 11, 2016
@darkdh darkdh self-assigned this Oct 11, 2016
@darkdh darkdh added this to the 0.12.6dev milestone Oct 11, 2016
@darkdh
Copy link
Member

darkdh commented Oct 15, 2016

Front end work is finished in https://github.com/brave/browser-laptop/tree/default-browser
And it works for Mac now. Working on electron API for windows and linux.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants