This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add whether brave is default browser check #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
default-browser
branch
from
05e80a0
to
1d34c59
Compare
bbondy
reviewed
Oct 19, 2016
| @@ -421,7 +423,6 @@ app.on('ready', () => { | |||
| basicAuth.init() | |||
| contentSettings.init() | |||
| privacy.init() | |||
| Autofill.init() | |||
There was a problem hiding this comment.
Was Autofill.init() removed here intentionally?
There was a problem hiding this comment.
Ah, no it must be a rebase mistake
bbondy
reviewed
Oct 19, 2016
| onUseBrave () { | ||
| appActions.defaultBrowserUpdated(true) | ||
| appActions.defaultBrowserCheckComplete() | ||
| appActions.changeSetting(settings.CHECK_DEFAULT_ON_STARTUP, this.props.checkDefaultOnStartup) |
There was a problem hiding this comment.
I wonder if all these 3 things could be managed by a single appAction instead. I won't block on it but I think that's preferred for future ref.
fix #2105 requires brave/muon#73 Auditors: @bridiver, @bbondy
darkdh
force-pushed
the
default-browser
branch
from
1d34c59
to
7eef889
Compare
|
looks great overall, I'll post followups for discovered problems. |
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #2105
requires brave/muon#73
Auditors: @bridiver, @bbondy