Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Horizontal scroll with two-finger conflicts with swipe back/forward #2548

Closed
luixxiul opened this issue Jul 17, 2016 · 11 comments · Fixed by #4083
Closed

Horizontal scroll with two-finger conflicts with swipe back/forward #2548

luixxiul opened this issue Jul 17, 2016 · 11 comments · Fixed by #4083
Assignees
@darkdh
Labels
OS/macOS QA/checked-macOS
Milestone
0.12.2dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 17, 2016 •
edited
Loading

Describe the issue you encountered:
Horizontal scroll with two-finger conflicts with swipe back/forward

Expected behavior:
@bbondy
Copy link
Member

bbondy commented Jul 18, 2016

cc @darkdh

@darkdh
Copy link
Member

darkdh commented Jul 18, 2016

@luixxiul , I can't reproduce it on 0.11.1 Beta 1. Could you provide more details?

@bbondy
Copy link
Member

bbondy commented Jul 18, 2016

You can reproduce by having both back and forward sites available in your urlbar history, and then scroll horizontally. Maybe the back and forward operation should be disabled for that gesture when the page is scrolling.

@darkdh darkdh self-assigned this Jul 18, 2016
@darkdh
Copy link
Member

darkdh commented Jul 18, 2016

I see, thanks @bbondy. I will work on it.

darkdh added a commit to darkdh/browser-laptop that referenced this issue Jul 18, 2016
@darkdh
Prevent two-finger swipe forard/back when scrolling
ddff3ff 
fix brave#2548
This was referenced Jul 18, 2016
Merged
Closed
@luixxiul
Copy link
Contributor Author

Fixed?

@darkdh
Copy link
Member

darkdh commented Jul 23, 2016

Not yet, #2553 fixed another problem of horizontal scroll conflict. Conflict with inner element scroll is not solved yet.

CC @bbondy

@darkdh darkdh mentioned this issue Aug 5, 2016
Merged
@bbondy bbondy added this to the 0.11.3dev milestone Aug 5, 2016
@darkdh darkdh reopened this Sep 17, 2016
@darkdh darkdh modified the milestones: 0.12.3dev, 0.11.3dev Sep 17, 2016
@darkdh
Copy link
Member

darkdh commented Sep 17, 2016

reopen because the original solution still not fixed the problem. working on a better way to solve it.

darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 17, 2016
@darkdh
1. Make swipe distance shorter
9e2d0ab 
2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix brave#2548, brave#4604

Auditors: @bbondy

Test Plan:
for swipe conflict
1. Go to https://hootsuite.com
2. Create timelines as much as you have to scroll horizontally
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 17, 2016
@darkdh
1. Make swipe distance shorter
8e0f5b1 
2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix brave#2548, brave#4604

Auditors: @bbondy

Test Plan:
for swipe conflict
1. Go to https://hootsuite.com
2. Create timelines as much as you have to scroll horizontally
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 17, 2016
@darkdh
1. Make swipe distance shorter
1b7c47e 
2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix brave#2548
fix brave#4604

Auditors: @bbondy

Test Plan:
for swipe conflict
1. Go to https://hootsuite.com
2. Create timelines as much as you have to scroll horizontally
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 17, 2016
@darkdh
1. Make swipe distance shorter
ba53da7 
2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix brave#2548, brave#4064

Auditors: @bbondy

Test Plan:
for swipe conflict
1. Go to https://hootsuite.com
2. Create timelines as much as you have to scroll horizontally
@darkdh darkdh mentioned this issue Sep 17, 2016
Merged
4 tasks
@darkdh darkdh modified the milestones: 0.12.2dev, 0.12.3dev Sep 17, 2016
MKuenzi pushed a commit to MKuenzi/browser-laptop that referenced this issue Sep 18, 2016
@darkdh @MKuenzi
1. Make swipe distance shorter
dfdfe01 
2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix brave#2548, brave#4064

Auditors: @bbondy

Test Plan:
for swipe conflict
1. Go to https://hootsuite.com
2. Create timelines as much as you have to scroll horizontally
This was referenced Sep 22, 2016
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 6, 2016

It seems that this started happening again on OS X.

@darkdh
Copy link
Member

darkdh commented Oct 6, 2016

@luixxiul the problem should be gone from 0.12.3. And I don't see this happen on 0.12.3

@luixxiul luixxiul mentioned this issue Nov 29, 2016
Closed
@cndouglas cndouglas mentioned this issue Feb 6, 2017
Closed
@badbabykosh
Copy link

Dear gawd HOW DO I turn OFF two-finger back/forward swipe? I can not find this setting anywhere in this browser. (note: I have no gestures configured for trackpad on macbook pro yet brave swipe back/forward is on and aggravating)

@luixxiul
Copy link
Contributor Author

The issue is tracked here: #7100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
OS/macOS QA/checked-macOS
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

Swipe behavior fix darkdh/browser-laptop
5 participants
@bbondy @alexwykoff @badbabykosh @luixxiul @darkdh