Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Swipe behavior fix #4083

Merged
merged 1 commit into from
Sep 18, 2016
Merged

Swipe behavior fix #4083

merged 1 commit into from
Sep 18, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
    1. Make swipe distance shorter
    2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix #2548, #4064

Test Plan:
for swipe conflict

  1. Go to https://hootsuite.com
  2. Create timelines as much as you have to scroll horizontally

2. Use scroll-touch-edge to solve swipe conflict

requires brave/muon#58

fix brave#2548, brave#4064

Auditors: @bbondy

Test Plan:
for swipe conflict
1. Go to https://hootsuite.com
2. Create timelines as much as you have to scroll horizontally
@bbondy
Copy link
Member

bbondy commented Sep 18, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scroll with two-finger conflicts with swipe back/forward
3 participants