Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Notification bar (restart dialog) for crashes does not dismiss #2926

Closed
luixxiul opened this issue Aug 4, 2016 · 1 comment
Closed

Notification bar (restart dialog) for crashes does not dismiss #2926

luixxiul opened this issue Aug 4, 2016 · 1 comment
Labels
bug
Milestone
0.11.2dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 4, 2016

Describe the issue you encountered: Notification bar (restart confirmation) for crashes does not dismiss

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.11.2 RC1
  • Steps to reproduce:
    1. Open about:preferences#advanced
    2. Change a pref that require restart to display a restart dialog
    3. process.crash()
  • Screenshot if needed:
    clipboard01
  • Any related issues: Manual tests for Win-x32 0.11.2 RC1 #2907
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 4, 2016

And also,

  1. Click No
  2. Click OK

the notification bar does not dismiss

@luixxiul luixxiul added the bug label Aug 4, 2016
@luixxiul luixxiul mentioned this issue Aug 4, 2016
Closed
99 tasks
@bbondy bbondy closed this as completed in f4b4c42 Aug 4, 2016
bbondy added a commit that referenced this issue Aug 4, 2016
@bbondy
Merge pull request #2930 from willy-b/issue-2926
140d534 
Fixes #2926 - Notification bar (restart dialog) for crashes does not dismiss
@luixxiul luixxiul added this to the 0.11.2dev milestone Aug 5, 2016
@willy-b willy-b mentioned this issue Aug 5, 2016
Merged
diracdeltas added a commit that referenced this issue Aug 8, 2016
@diracdeltas
Merge pull request #2995 from willy-b/issue-2926
744c2a9 
Simplify change for #2926 w/ ipcMain.removeListener
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.11.2dev
Development

No branches or pull requests
1 participant
@luixxiul