Fixes #2926 - Notification bar (restart dialog) for crashes does not dismiss #2930
Conversation
willy-b
commented
Aug 4, 2016
willy-b
commented
- Used Github auto-closing keywords in the commit message.
|
Wow, thanks for the quick patch! |
|
NP, thanks to everyone for running such an open project :-D |
| } | ||
| }) | ||
| } | ||
| ipcMain.once(messages.NOTIFICATION_RESPONSE, notificationResponseCallback) |
There was a problem hiding this comment.
nice catch! may be simpler to change this to ipcMain.on and then call ipcMain.removeListener when message === locale.translation('unexpectedErrorWindowReload')
There was a problem hiding this comment.
ditto! opened a PR to switch to ipcMain.removeListener and I agree this way is much simpler. thanks :-)
|
Thanks! I'll pull this in since I'm running RC builds now, but feel free to do a follow up for Yan's comment. |
|
Whoops, somehow missed notifications for this PR! (I always prefer web to apps, but I think I may need a GitHub app of some kind for notifications to keep up with Brave :-D) The follow up PR for Yan's comment is open: #2995. |
