Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Support tray progress bars for downloaded items #3023

Closed
bbondy opened this issue Aug 7, 2016 · 5 comments
Closed

Support tray progress bars for downloaded items #3023

bbondy opened this issue Aug 7, 2016 · 5 comments

Comments

@bbondy
Copy link
Member

bbondy commented Aug 7, 2016

Test plan

#9864 (comment)

  1. Go to https://brave.com/downloads.html
  2. Download one of the builds
  3. Notice the taskbar icon has a progress bar. If macOS, a badge is shown with # of concurrent downloads

Original issue description

BrowserWindow has a way to set progress which shows up in the tray. This is useful for downloading items. We should show the overall progress of all downloads in the try w/ BrowserWindow's setProgressBar

@bbondy bbondy added the shell-integration Integrating brave with OS-level UI features. label Aug 7, 2016
@bbondy
Copy link
Member Author

bbondy commented Aug 7, 2016

We should also set the electron.app.dock's dock.setBadge with the number of downloads that are active when > 0

@bsclifton
Copy link
Member

Here's a great page for reference, for anyone wanting to tackle this 😄
http://electron.atom.io/docs/tutorial/desktop-environment-integration/

@bsclifton bsclifton added the help wanted The PR/issue opener needs help to complete/report the task. label Aug 11, 2016
@jonathansampson jonathansampson added this to the Backlog milestone Mar 14, 2017
@chirag64
Copy link

Hi,

I'd like to attempt a PR for this.

I tried setting the setProgressBar to a hard coded value and I was able to set the progress bar of the icon in the taskbar. The place where I'm guessing we need to add this code is in electronDownloadItem.js inside the updateElectronDownloadItem().

But I'm unable to find the download percent at this location. I would appreciate some help with this.

Please let me know if I'm approaching this the wrong way.

timborden added a commit to timborden/browser-laptop that referenced this issue Jul 5, 2017
@timborden
Copy link
Contributor

Hey @bbondy and @bsclifton, I just submitted a PR #9864 for this

@NejcZdovc NejcZdovc modified the milestones: 0.20.x (Nightly Channel), Backlog Jul 5, 2017
@srirambv
Copy link
Collaborator

srirambv commented Jul 6, 2017

bsclifton pushed a commit to timborden/browser-laptop that referenced this issue Jul 28, 2017
@bsclifton bsclifton added QA/test-plan-specified release-notes/include and removed help wanted The PR/issue opener needs help to complete/report the task. labels Jul 28, 2017
@bsclifton bsclifton self-assigned this Jul 28, 2017
bsclifton added a commit that referenced this issue Jul 29, 2017
Added download count/badge and progress (closes #3023)
bsclifton added a commit that referenced this issue Jul 29, 2017
Added download count/badge and progress (closes #3023)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants