Added download count/badge and progress (closes #3023)

[timborden]

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Closes #3023

Test Plan:

• I tested manually. There didn't appear to be any unit tests for /app/browser/updateElectronDownloadItem.js

  1. Go to https://brave.com/downloads.html
  2. Download one of the builds
  3. Notice the taskbar icon has a progress bar. If macOS, a badge is shown with # of concurrent downloads

• I can add tests that check the badge count (app.getBadgeCount), if you think it's necessary...although it feels like we're testing electron code with that

• I can write unit tests for the progress calculations, if you think it's necessary

Notes:

• I'm not sure I like having to pass win into the updateDownloadState and updateElectronDownloadItem functions....but there didn't seem to be a better way. If you've got a better approach...I'm happy to refactor.

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[bsclifton]

@timborden sorry for the super long turn-around... finally trying this out now 😄

[bsclifton]

Here's what it looks like on macOS:

It also does properly track # of downloads:

[codecov-io]

Codecov Report

Merging #9864 into master will decrease coverage by 0.05%.
The diff coverage is 23.33%.

@@            Coverage Diff             @@
##           master    #9864      +/-   ##
==========================================
- Coverage   52.81%   52.76%   -0.06%     
==========================================
  Files         227      227              
  Lines       20192    20218      +26     
  Branches     3233     3236       +3     
==========================================
+ Hits        10665    10668       +3     
- Misses       9527     9550      +23

Flag	Coverage Δ
#unittest	52.76% <23.33%> (-0.06%)	⬇️

Impacted Files	Coverage Δ
app/filtering.js	18.33% <0%> (ø)	⬆️
app/browser/electronDownloadItem.js	42.55% <26.92%> (-24.12%)	⬇️
js/stores/appStoreRenderer.js	91.17% <0%> (-8.83%)	⬇️

[bsclifton]

Here's how it looks on Windows:

Unlike macOS, Windows doesn't have a badge with # of downloads. Looks good though! I did notice that after the download is complete, the icon in the taskbar stays green (like 100%) forever.

@timborden can you check that out? I checked Chrome on Windows and the progress goes away once the download hits 100%. We want to do that also
edit: I tried again and it works great

[bsclifton]

I just re-tried and it worked great, as expected 😄 Great job on this one!

[bsclifton]

NOTE: I tried on Linux (using Ubuntu 14 with Gnome 3) and I didn't see the progress bar or any badges (it just behaved regularly).

[bsclifton]

Congrats on your first contribution, @timborden 😄 👍 (and huge thanks!)

[luixxiul]

@timborden It looks great! Looking forward to see it on board :-)

[timborden]

Thanks @bsclifton and @luixxiul!

(just spotted that this was merged...sorry for not picking up the earlier messages....adjusting GitHub settings now)