Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New Tab Always gets focus when "Switch to new tabs immediately" is disabled #3068

Closed
rjventrone opened this issue Aug 10, 2016 · 1 comment
Closed

New Tab Always gets focus when "Switch to new tabs immediately" is disabled #3068

rjventrone opened this issue Aug 10, 2016 · 1 comment
Labels
wontfix

Comments

@rjventrone
Copy link

Every time open a new tab it takes focus. Even when "Switch to new tabs immediately" is disabled.

Expected behavior:
I expect the new tab not to get focus when "Switch to new tabs immediately" is disabled.

  • Platform:
    OSX 10.11.6
  • Brave Version:
    0.11.3
  • Steps to reproduce:
    1. make sure "Switch to new tabs immediately" is disabled
    2. ctrl + t
Autokrator pushed a commit to Autokrator/browser-laptop that referenced this issue Aug 10, 2016
Fixes brave#3068 Implements 'Switch to new tabs immediately' setting'
ec660c1 
Configure openInForeground to use browser settings

Fix issue where openInForeground definition check failed and make bookmarks conform to browser settings
Autokrator pushed a commit to Autokrator/browser-laptop that referenced this issue Aug 10, 2016
Fixes brave#3068 Implements 'Switch to new tabs immediately' setting'
46d5058 
Configure openInForeground to use browser settings

Fix issue where openInForeground definition check failed and make bookmarks conform to browser settings

Add space after if
@bsclifton bsclifton mentioned this issue Aug 22, 2016
Closed
Autokrator pushed a commit to Autokrator/browser-laptop that referenced this issue Sep 5, 2016
Fixes brave#3068 Implements 'Switch to new tabs immediately' setting'
2ff886f 
Configure openInForeground to use browser settings

Fix issue where openInForeground definition check failed and make bookmarks conform to browser settings

Add space after if
Autokrator pushed a commit to Autokrator/browser-laptop that referenced this issue Sep 5, 2016
Fixes brave#3068 Implements 'Switch to new tabs immediately' setting
9b9f7f3
@rickycodes rickycodes mentioned this issue Sep 27, 2016
Closed
GreenRecycleBin added a commit to GreenRecycleBin/browser-laptop that referenced this issue Nov 24, 2016
@GreenRecycleBin
Open all bookmark items under a bookmark folder in foreground tabs
85e51a9 
If SWITCH_TO_NEW_TABS is truthy

Auditors: Unsure what to fill in here

Test Plan:
  - Simulate middle clicking a bookmark folder
  - Check that as many new foreground tabs are opened with the same URLs of the
  bookmarks in order (or just check that all such events are fired in order if
  URL checks are not feasible)

Fix brave#3068.
@GreenRecycleBin GreenRecycleBin mentioned this issue Nov 24, 2016
Merged
@bsclifton bsclifton modified the milestone: 0.13.0 Nov 26, 2016
@bsclifton
Copy link
Member

I'm going to close this issue as won't fix, but I welcome feedback from folks
cc: @bradleyrichter @bbondy

The "Switch to new tabs immediately" setting (if set to true) was intended to switch focus to a newly created tab when you middle click a link or click a link which has a target of _blank. It's not related to what happens when you create a new tab.

This issue is specifically asking for that setting to be respected when opening a new empty tab by clicking the + in the tabs area or by pressing Ctrl + T / Cmd + T. The impact would be: opening a new tab does not switch to it. You'd have to manually click the empty tab or use a keyboard shortcut to switch the tab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3068
2 participants
@rjventrone @bsclifton